Skip to content

Fix dune/opam files having outdated giflib#123

Merged
pawaskar-shreya merged 2 commits into
mainfrom
mwd-update-giflib-dependancy
Sep 17, 2025
Merged

Fix dune/opam files having outdated giflib#123
pawaskar-shreya merged 2 commits into
mainfrom
mwd-update-giflib-dependancy

Conversation

@mdales
Copy link
Copy Markdown
Collaborator

@mdales mdales commented Sep 16, 2025

The most recent opam update for Claudius failed: ocaml/opam-repository#28530

The reason was because opam sensibly tests packages with the minimum version of each dependancy as specified in the opam file, and when I moved Claudius to use the simplified giflib interface recently, I didn't update the version number in the dune-project file or Claudius.opam file. This was a bug our own CI missed, but thankfully the opam one detected.

In this PR I do two things:

  1. I make our CI now do the same thing the opam CI does by specifying the same three environmental variables that the opam CI does which tell opam to install the minimum version of each package Claudius depends on. With that set, I could get our CI to also fail!
  2. I updated dune-project and Claudius.opam to have the right version, making our CI then pass.

@mdales mdales force-pushed the mwd-update-giflib-dependancy branch from 2169eb3 to ebcd029 Compare September 16, 2025 21:05
@mdales mdales force-pushed the mwd-update-giflib-dependancy branch from ebcd029 to 2defc41 Compare September 16, 2025 21:12
@mdales mdales force-pushed the mwd-update-giflib-dependancy branch from 94841c2 to 6eb4a3e Compare September 16, 2025 21:20
@pawaskar-shreya
Copy link
Copy Markdown
Collaborator

The reason was because opam sensibly tests packages with the minimum version of each dependancy as specified in the opam file

Yupp, this was the same reason my PR on opam had failed!

@pawaskar-shreya pawaskar-shreya merged commit 2e0aadd into main Sep 17, 2025
1 check passed
@mdales mdales deleted the mwd-update-giflib-dependancy branch September 17, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants