Rename "Client Trust" to "Device Trust" in skill content - #59
Open
mwickett wants to merge 2 commits into
Open
Conversation
Part of PROT-875. The clerk.com guide these skills accompany is now titled Device Trust, and it tells agents to install this bundle -- so the old name here contradicts the docs it ships alongside. Copy only. The `needs_client_trust` status value is unchanged, since the API is not being renamed.
skills/mobile/clerk-expo/evals/evals.json described the expected output as "MFA/client-trust branches handled". The needs_client_trust status value in the same eval is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PROT-875. Independent — no ordering constraint.
Clerk renamed the customer-facing feature "Client Trust" → "Device Trust". This repo was flagged by @manovotny while reviewing clerk/clerk#3051: the renamed guide at
/docs/guides/secure/device-trustexplicitly tells agents to install these skills, so leaving the old name here means the docs and the skills disagree.Changes — copy only, 2 lines
skills/core/clerk-custom-ui/core-3/custom-sign-in.md— the## Client Trustsection headingskills/core/clerk-cli/references/recipes.md— one sentence of proseNot changed
The
needs_client_truststatus value is untouched, here and everywhere else in the rename. Per Kyle in the naming thread: "we don't have to change APIs but the way we discuss clients externally should flip to devices." The code sample incustom-sign-in.mdstill checkssignIn.status === 'needs_client_trust', which remains correct.Related