feat: add Acid Tools footer badge#78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Add an Acid Tools badge to the public footer using the supplied light and dark hosted badge images and link, following the PR workflow without creating a blog post.
Summary
Adds an accessible, theme-aware Acid Tools directory badge to the public xpenser footer and verifies the integration at component and browser-test levels.
What changed
AcidToolsBadgeto the public footer badge collection.https://acidtools.com/assets/images/badge.pngin light mode andhttps://acidtools.com/assets/images/badge-dark.pngin dark mode.Acid Toolsalt text, 54px height, lazy loading, target URL, and new-tab behavior while adding the repository-standard focus styling and safe link relation.Reasoning
The implementation follows the existing hosted footer-badge pattern so the new badge participates in the same responsive wrapping, focus treatment, and dark-mode switching. The supplied markup does not define a width, so the implementation intentionally leaves width intrinsic rather than inventing a dimension. The e2e flow triggers lazy loading as a user would before checking the rendered theme variant.
Blog post
Skipped by explicit user request. This badge-only addition is too small to justify a standalone release post.
Screenshots / preview evidence
Preview: https://xpenser-pr-078.cleverbrush.com
Manual QA exercised the footer at 390 × 844 and 1440 × 900 in light and dark themes, with light/dark mobile and desktop screenshots captured during the session. Verified:
target="_blank",rel="noopener noreferrer", alt text, height, and lazy-loading attributes are present.The passing Playwright e2e job provides stable CI evidence for the updated public homepage flow.
Validation
npm test -- apps/web/components/landing-page.test.tsxnpm run lintnpm run typechecknpm test(95 files, 520 tests)PLAYWRIGHT_BASE_URL=https://xpenser-pr-078.cleverbrush.com npm run test:e2e -- tests/e2e/public-auth.spec.ts(6 tests)xpenser-web-pr-78never appeared as a trace or log resource and the queried metric series were empty127.0.0.1:8787was unavailableTelemetry
For the post-QA
xpenser-web-pr-78window:http.server.duration.countandnodejs.eventloop.utilizationreturned no matching metric series.xpenser-web-pr-77but does not contain PR 78 for traces or logs, even after an ingestion wait and recheck.Screenshots / Preview
See the preview evidence above and the passing Playwright job for stable browser-test evidence.
Checklist