feature/cp-11483-make-banner-non-blocking#347
Open
unnaticleverpush wants to merge 2 commits into
Open
Conversation
Added support for non-blocking in-app banners to allow background interaction while banners are visible.
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cleverpush/src/main/java/com/cleverpush/banner/AppBannerPopup.java">
<violation number="1" location="cleverpush/src/main/java/com/cleverpush/banner/AppBannerPopup.java:801">
P1: `applyMeasuredHtmlBannerBounds` is invoked from the JavaScript bridge but updates `PopupWindow` views directly; Java bridge callbacks run off the UI thread, so this will throw `CalledFromWrongThreadException` when measurements arrive. Post the work to the main thread before mutating views.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Fix non-blocking HTML banner popup updates to run on UI thread
harkeshkumar196
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for non-blocking in-app banners to allow background interaction while banners are visible.
Summary by cubic
Makes in‑app banners non‑blocking so users can interact with the app while a banner is visible. Adds an opt‑in flag, resizes HTML banner popups to wrap only the banner area, and ensures popup updates run on the UI thread. (Linear CP‑11483)
New Features
appBannersNonBlockingflag toCleverPushwithsetAppBannersNonBlocking/isAppBannersNonBlocking.setHtmlBannerBounds;AppBannerPopup.applyMeasuredHtmlBannerBoundsshrinks the popup to that rect on the UI thread.WRAP_CONTENTand non-modal touch so background stays interactive; gravity-aware positioning for top/bottom.Migration
CleverPush.getInstance(context).setAppBannersNonBlocking(true).Written for commit 74f3253. Summary will update on new commits.