hotfix/cp-11502-firebase-messaging-library-outdated#348
Open
unnaticleverpush wants to merge 2 commits into
Open
hotfix/cp-11502-firebase-messaging-library-outdated#348unnaticleverpush wants to merge 2 commits into
unnaticleverpush wants to merge 2 commits into
Conversation
Update Firebase Messaging dependency range to support v25.x versions
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cleverpush/build.gradle">
<violation number="1" location="cleverpush/build.gradle:88">
P2: The new version range only permits `25.0.x`, not all `25.x` versions. Use an exclusive `26.0.0` upper bound if the goal is to allow any `25.*` release.</violation>
</file>
<file name="cleverpush-example/build.gradle">
<violation number="1" location="cleverpush-example/build.gradle:11">
P2: `minSdkVersion` was raised higher than needed for Firebase Messaging 25.x. Use API 23 (FCM requirement) instead of 25 to avoid unnecessary compatibility loss in the example app.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Expand Firebase Messaging dependency range to allow all 25.x versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Firebase Messaging dependency range to support v25.x versions
Summary by cubic
Extends the supported range for
com.google.firebase:firebase-messagingto include all v25.x releases, addressing Linear CP-11502. Also raises the example appminSdkVersionto 23.com.google.firebase:firebase-messagingto[10.2.1, 26.0.0)(was[10.2.1, 24.0.99]).Written for commit 35ddb5d. Summary will update on new commits.