hotfix/cp-11317-ios-android-ensure-channelid-validation-before-executing-api#374
Merged
snuricp merged 2 commits intoApr 16, 2026
Conversation
…ing-api Added functionality for preventing the API calls if there is no channelID
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CleverPush/Source/CleverPushInstance.m">
<violation number="1" location="CleverPush/Source/CleverPushInstance.m:1191">
P1: Early return on empty channelId skips unsubscribe completion handling (no callback/failure/local cleanup).</violation>
<violation number="2" location="CleverPush/Source/CleverPushInstance.m:1191">
P1: Early return on empty channelId can deadlock `removeSubscriptionTags` completion (dispatch group never leaves).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…ing-api Added functionality for preventing the API calls if there is no channelID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for preventing the API calls if there is no channel ID
Summary by cubic
Validate channelId before executing API calls across the iOS SDK to prevent invalid requests and noisy errors. Implements CP-11317 by only calling the backend when a valid channelId is present.
CPUtils isNullOrEmptychannelId guards acrossCleverPushInstance,CPAppBannerModuleInstance, andCPInboxView(banners and banner events, subscription sync/unsubscribe, notifications delivered/clicked, tags/attributes/topics and attribute push/pull, sessions start/end, analytics/conversions/follow-ups, inbox clicked, live activities, campaigns, notifications fetch).subscriptionInProgresson sync; return cached notifications if channelId is missing; keep callbacks where applicable.Written for commit 292736c. Summary will update on new commits.