feature/cp-10601-make-banner-non-blocking

[cpandya25]

implemented functionality of allow users to interact with app while in-app banner is visible.

---

Summary by cubic

Allows in-app banners to be non-blocking so users can keep using the app while a banner is visible. Default stays modal; opt in via a new API. Addresses CP-10601.

• New Features
  • Added +[CleverPush setAppBannersNonBlocking:] (also on CleverPushInstance and CPAppBannerModule) to switch to a pass-through overlay.
  • Non-blocking mode embeds CPAppBannerViewController as a child and uses CPAppBannerPassthroughView to forward touches outside the banner while keeping the close button active.
  • Unified dismissal via windowDismissBlock; when a banner action opens Safari and dismisses, we dismiss first, then open the link. Modal flow is unchanged.

^{Written for commit 05595c1. Summary will update on new commits.}

[cubic-dev-ai]

3 issues found across 14 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CleverPush/Source/CPAppBannerPassthroughView.m">

<violation number="1" location="CleverPush/Source/CPAppBannerPassthroughView.m:16">
P1: HTML banners can still block app interaction because all touches inside the full-screen WKWebView are treated as banner touches.</violation>
</file>

<file name="CleverPush/Source/CPAppBannerModuleInstance.m">

<violation number="1" location="CleverPush/Source/CPAppBannerModuleInstance.m:1704">
P2: Avoid capturing `appBannerViewController` strongly inside its own `windowDismissBlock`; this creates a retain cycle and can leak dismissed banner controllers.</violation>
</file>

<file name="CleverPush/Source/CPBannerCardContainer.m">

<violation number="1" location="CleverPush/Source/CPBannerCardContainer.m:592">
P1: Forwarding dismiss to `self.controller onDismiss` causes duplicate `showNextActivePendingBanner` calls in dismiss flows, which can lead to duplicate/unstable pending-banner presentation.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CleverPush/Source/CPAppBannerViewController.m">

<violation number="1" location="CleverPush/Source/CPAppBannerViewController.m:838">
P1: Handle JavaScript height-evaluation failures in non-blocking mode; returning early leaves the HTML web view full-screen and can make the “non-blocking” overlay block app interaction.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CleverPush/Source/CPAppBannerViewController.m">

<violation number="1" location="CleverPush/Source/CPAppBannerViewController.m:858">
P2: Disabling `webView.userInteractionEnabled` on height-evaluation failure makes the HTML banner (including its close button) non-interactive, which can leave an undismissable banner visible.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}