Conversation
Removed Python 3.8 from envlist and updated mypy basepython to 3.12.
There was a problem hiding this comment.
Pull request overview
This PR removes Python 3.8 from the supported versions in the tox configuration and updates the mypy test environment to use Python 3.12. The removal of Python 3.8 aligns with the codebase's use of PEP 585-style type hints (e.g., dict[str, Any]) which require Python 3.9+. Additionally, the PR fixes a pre-existing typo where mypy was configured to use python3.3 instead of a modern Python version.
Changes:
- Removed Python 3.8 from the tox envlist
- Removed the gh-actions mapping for Python 3.8
- Updated mypy basepython from 3.3 to 3.12 (fixing a typo)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Python 3.8 from envlist and updated mypy basepython to 3.12.