Fix tool invocation, add NUnit constraints, wire attributes#1
Merged
Conversation
- AgentRunner now wraps the IChatClient in FunctionInvokingChatClient so the tools the model calls are actually executed. Previously the runner recorded FunctionCallContent but nothing fed results back, so against a real LLM the loop would spin until max turns with no progress. - Add Ngentic.NUnit Constraint-based API: Did.CallTool, Did.NotCallTool, Did.CallToolsInOrder, Did.MakeToolCalls. Plays with NUnit's Assert.That, Assert.Multiple, and the rich failure formatter. WithArg/WithArgs lets tests assert on tool arguments, not just the name. - AgenticTestBase now reads [MaxTurns] and [Model] from the current test method in [SetUp] and threads them into AgentBuilder so the attributes do something instead of being silent. - Thread modelId through AgentRunner into ChatOptions.ModelId. - Add ToolCall.CallId so calls and results are paired by id, not by index/best-effort. - New Ngentic.Tests project covering constraints, the legacy Expect DSL, and the runner's tool-invocation + model-id + system-prompt plumbing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of stuff