Feature/processing steps slider - #92
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Honor max_processing_step in analysis, fix slider bypass when questions are selected, and show chunk-only results after partial runs.
Reset the analyzer singleton per test so cache/chunks do not leak across cases and flake embed/chunk assertions.
0502459 to
acb05e9
Compare
Black/isort/ruff were failing CI test_linting and QG; expand tests so changed-line coverage clears the 90% gate.
|
|
||
|
|
||
| def test_normalize_processing_step_via_custom_label(monkeypatch): | ||
| import report_analyst.core.analyzer as analyzer_mod |
Keep pre_retrieved_chunks and max_processing_step kwargs; retain selected_question_ids_from_editor for analyze button selection.
Main's AppTest mocks rejected the processing-steps kwarg and failed CI.
mounacheikho-cmd
left a comment
mounacheikho-cmd
left a comment
There was a problem hiding this comment.
The Question Mapping step was running indefinitely on my machine while waiting for embedding or LLM requests. The reason seems to be that there is no timeout or cancellation handling
I looked a bit into this. We could set a shorter timeout, but do you know what's the actual problem, why you didn't get a response from openai? |
- Fail fast with max_retries=0 and a 60s request timeout - Re-raise permanent quota errors instead of swallowing them - Prove stock LlamaIndex retries a bounded 110 times then stops
| _PERMANENT_QUOTA_CODES = frozenset({"insufficient_quota", "credit_balance_exhausted"}) | ||
|
|
||
|
|
||
| def is_permanent_openai_quota_error(exc: BaseException) -> bool: |
There was a problem hiding this comment.
@mounacheikho-cmd does this fix the problem? It retried quota-errors for a long time.
Keep processing-step slider and fail-fast OpenAI clients; add PDF viewer from main on analyze and All Results.
Main now passes display_pdf_viewer into the consolidated view.
Keep PDF viewer errors from crashing the app and format cache_manager for black 26.
2 participants
Acceptance Criteria