Parity round 2: lock:check, test hardening, workflow security, CodeQL, tag gate - #38
Merged
Conversation
…, zizmor + SHA-pinned actions + least-privilege permissions, codeql, tag/version gate in release-verify (#37) branch coverage exposed untested selective backup/restore paths (tests added), and the new selective tests exposed swapped mock parameter names in the legacy test_backup/test_restore signatures (decorators inject bottom-up) - fixed
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #36 (retargets to master when it merges). Closes #37 — the remaining applicable checks from git-auto-merge PR #12.
uv lock --checkas its own row; catches pyproject/uv.lock drift-tpaths in backup()/restore() were never tested with an actual selection — added tests for both. Those new tests then exposed a latent bug in the legacy test signatures:@patchdecorators inject bottom-up, andtest_backup/test_restorehad their first two mock parameter names swapped (invisible when asserting everything-was-called). Fixed. Coverage: 97.02% branch, floor stays 95.lint:actions(now clean: was 8 mediumartipackedfindings); all actions SHA-pinned with version comments (dependabot keeps bumping them); least-privilegepermissions: contents: readeverywhere;persist-credentials: falseon every checkout; release tag moved to env-var indirection in run blocks (template-injection hygiene)version.py== release tag before testing the install (v1.0.27's match was manual luck; now enforced)rite check(now includes lock:check) green end-to-end locally.🤖 Generated with Claude Code