feat: Upgrade Node.js from 18.x to 24.x LTS#5
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
Conversation
- Update .nvmrc from 18 to 24 - Update package.json engines to >=24.0.0 <25.0.0 - Upgrade better-sqlite3 from ^9.6.0 to ^12.9.0 (required for Node 24 compatibility) - Update README documentation to reflect Node 24 - All 53 tests passing, lint clean, UI verified working Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Node.js runtime from 18.x (EOL) to 24.x LTS (Krypton, v24.15.0).
Changes
.nvmrc:18→24package.jsonengines:>=18.0.0 <19.0.0→>=24.0.0 <25.0.0better-sqlite3:^9.6.0→^12.9.0(v9 has no prebuilt binaries for Node 24 and fails to compile)package-lock.json: regenerated with npm 11.12.1README.md: all Node 18 references updated to Node 24Review & Testing Checklist for Human
better-sqlite3v12.x API is backward-compatible with existing usage (it is — the sync API is unchanged, but worth a spot-check)npm testlocally with Node 24 to confirm all 53 tests passnpm run dev) and verify the UI loads and CRUD operations workNotes
eslint) passes cleanbetter-sqlite3(v9 → v12) due to native addon compilation requirements for Node 24eslint@8,supertest@6, andsuperagent@8are pre-existing and unrelated to this upgradeLink to Devin session: https://app.devin.ai/sessions/caf1ccb8c62e44bc854f6add6724b29c
Requested by: @clivingston-cognition