chore: migrate from Node 18 to Node 20#8
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Update .nvmrc from 18 to 20 - Update engines field in package.json to >=20.0.0 <21.0.0 - Update ESLint config to es2022/ecmaVersion 2022 - Update description to reflect Node.js 20 - Rebuild better-sqlite3 native addon for Node 20 - All 54 tests pass, lint clean, 0 npm audit vulnerabilities Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the TODO List application runtime from Node.js 18 to Node.js 20 (one major version increment per the migration playbook).
Migration Checklist
.nvmrc18→20package.jsonengines>=18.0.0 <19.0.0→>=20.0.0 <21.0.0package.jsondescription.eslintrc.jsones2021/ecmaVersion 2021→es2022/ecmaVersion 2022better-sqlite3What was NOT changed (and why)
eslint.config.js), which is a separate effort.url.parse(),Buffer()constructor,fs.exists(),require('punycode'),process.binding(),util.isArray(),util.isFunction(). None present.Verification
eslint src/ tests/)Review & Testing Checklist for Human
nvm use 20 && npm rebuild && npm testto verify all 54 tests pass on your machinenpm startand verify the app serves at http://localhost:3000better-sqlite3WAL mode and CRUD operations work via the UI or APINotes
better-sqlite3native addon (v9.6.0) supports Node 20 out of the box — only a rebuild is needed, no version bump required.Link to Devin session: https://app.devin.ai/sessions/b85d4eb55ec54bba8869439b7055afbd
Requested by: @clivingston-cognition