WIP: refactoring methods in tests and adding tests for plugins#1346
Open
omgoswami wants to merge 18 commits intocloud-ark:masterfrom
Open
WIP: refactoring methods in tests and adding tests for plugins#1346omgoswami wants to merge 18 commits intocloud-ark:masterfrom
omgoswami wants to merge 18 commits intocloud-ark:masterfrom
Conversation
…estions on plugins/appstatus.py
| # register HelloWorldService API | ||
| cmd = "kubectl create -f ../examples/multitenancy/hello-world/hello-world-service-composition-localchart.yaml --kubeconfig=%s" % provider | ||
| TestKubePlus.run_command(cmd) | ||
| self.setup_example_hello_world(provider=provider) |
Contributor
There was a problem hiding this comment.
Don't need 'provider=provider', since provider is not a keyword argument in line 50.
Just pass provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored setup and cleanup methods for testing with examples/hello-world
adding test cases for kubectl connections, appresources, appurl, applogs, and metrics