Skip to content

Add ability to test PRs from kube-burner-ocp repositories instead of only using release versions #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sraviteja-maker wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add ability to test PRs from kube-burner-ocp repositories instead of only using release versions #816

sraviteja-maker wants to merge 8 commits into from

Conversation

@sraviteja-maker
Copy link

@sraviteja-maker sraviteja-maker commented Nov 19, 2025

Type of change

  • New feature

Description

  • Add KUBEBURNER_OCP_PR env var (empty by default)
  • Add build_from_pr() function to clone, build, and use PR code
  • Include architecture detection for arm64/amd64 builds
  • Maintain backward compatibility with download_binary() as default

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sraviteja-maker
Once this PR has been reviewed and has the lgtm label, please assign avasilevskii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sraviteja-maker
Add ability to test PRs from kube-burner-ocp repositories instead of …
2f5c7a9 
…only using release versions

Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker sraviteja-maker force-pushed the kubeburner_ocp_pr_testing branch from 48f0d42 to 2f5c7a9 Compare November 19, 2025 06:04
@sraviteja-maker
Copy link
Author

sraviteja-maker commented Nov 19, 2025

Testing these changes as part of openshift/release#70747

@sraviteja-maker
Updated GIT global user settings to rectify pull with rebase errors
90338af 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker
Updated GIT Global user settings in run.sh as well to test through PR…
fa027ad 
…OW CI

Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker
Add automatic Go installation with version checking
21d2bd1 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
Assisted-by: Cursor
@sraviteja-maker sraviteja-maker marked this pull request as ready for review November 21, 2025 11:35
@sraviteja-maker
Removed the git config global user settings
b871fc1 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker
Use fetch and rebase flow for PR cloning
566ece7 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker
Reverted the git config global user settings and PR Cloning method
4c0e104 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker
Updated the proper values for GIT global user settings
da45c7d 
Signed-off-by: Raviteja Sahukari <rsahukar@redhat.com>
@sraviteja-maker sraviteja-maker force-pushed the kubeburner_ocp_pr_testing branch from 36e1746 to da45c7d Compare November 27, 2025 05:54
@sraviteja-maker
Copy link
Author

sraviteja-maker commented Nov 27, 2025

Tested the changes successfully as part of this PR openshift/release#70747

@sraviteja-maker
Copy link
Author

sraviteja-maker commented Nov 28, 2025 •
edited
Loading

@paigerube14 / @venkataanil When you have a moment, please review this PR.

rsevilla87
rsevilla87 reviewed Dec 2, 2025
View reviewed changes
workloads/kube-burner-ocp-wrapper/run.sh
curl --fail --retry 8 --retry-all-errors -sS -L "${KUBE_BURNER_URL}" | tar -xzC "${KUBE_DIR}/" kube-burner-ocp
}

install_go(){
Copy link
Member

@rsevilla87 rsevilla87 Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing golang should be out of scope of this repository, we don't usually do modifications in the local environment where these scripts run

@rsevilla87 rsevilla87 self-requested a review December 2, 2025 14:28
rsevilla87
rsevilla87 reviewed Dec 2, 2025
View reviewed changes
workloads/kube-burner-ocp-wrapper/run.sh
fi
}

build_from_pr(){
Copy link
Member

@rsevilla87 rsevilla87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this function to a different bash file?, I'd like to keep this one as simple as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsevilla87 rsevilla87 rsevilla87 left review comments

@paigerube14 paigerube14 Awaiting requested review from paigerube14

@venkataanil venkataanil Awaiting requested review from venkataanil

@jtaleric jtaleric Awaiting requested review from jtaleric

@vishnuchalla vishnuchalla Awaiting requested review from vishnuchalla

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sraviteja-maker @rsevilla87