-
Notifications
You must be signed in to change notification settings - Fork 43
Fix small inconsistencies #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| + g.panel.row.withGridPos({ x: 0, y: 0, w: 24, h: 1 }) | ||
| + g.panel.row.withCollapsed(true) | ||
| + g.panel.row.withPanels([ | ||
| panels.timeSeries.genericLegend('ovnkube-control-plane CPU Usage', 'percent', queries.ovnKubeControlPlaneCPU.query(), { x: 0, y: 1, w: 12, h: 8 }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot changes to re-order the panels. ovnkube-control-plane is a lighter pod, so it is at the bottom now. ovnkube-controller is now at the top as it is the resource hog.
| panels.timeSeries.generic('Routes count', 'none', queries.routesCount.query(), { x: 0, y: 20, w: 8, h: 8 }), | ||
| panels.timeSeries.generic('Alerts', 'none', queries.alerts.query(), { x: 8, y: 20, w: 8, h: 8 }), | ||
| panels.timeSeries.genericLegend('Pod Distribution', 'none', queries.podDistribution.query(), { x: 16, y: 20, w: 8, h: 8 }), | ||
| panels.timeSeries.genericLegend('Top 10 container RSS', 'bytes', queries.top10ContMem.query(), { x: 0, y: 28, w: 24, h: 8 }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reordered and resized to be consistent with all other sections, where CPU and Memory split a horizontal row, in that order.
| ovnAnnotationLatency: { | ||
| query(): | ||
| generateTimeSeriesQuery('histogram_quantile(0.99, sum by (pod, le) (rate(ovnkube_controller_pod_creation_latency_seconds_bucket[$interval]))) > 0', '{{ pod }}'), | ||
| generateTimeSeriesQuery('histogram_quantile(0.99, sum by (instance, pod, le) (rate(ovnkube_controller_pod_creation_latency_seconds_bucket[$interval]))) > 0', '{{ pod }} - {{ instance }}'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a label to the OVN Latency panels, to help trace the pods to nodes without having to query the API. Assumes we know a node's IP address.
Reorder OVN panels as ovnkube-control-plane is not the first priority any longer. Units missing on CGroup summary panel CGroups panels updated to find the ovs.slice.
Signed-off-by: Andrew Collins <ancollin@redhat.com>
4060d67 to
bb62534
Compare
Type of change
Description
Reorder OVN panels as ovnkube-control-plane is not the first priority any longer. Units missing on CGroup summary panel
CGroups panels updated to find the ovs.slice.
Checklist before requesting a review
Testing