Skip to content

test(nix): fix race condition in portail-identity-aware-upstream #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealHinome wants to merge 1 commit into from
Closed

test(nix): fix race condition in portail-identity-aware-upstream #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nix/tests/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,12 @@ in
"curl --fail --max-time 5 https://hello.corp.example.com/"
)

# Wait until the proxy has fully established its internal tunnel.
node.wait_until_succeeds(

@rlahfa-dinum rlahfa-dinum Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't understand how this is fixing anything here. The next line is going to be doing the very much same thing. Can you explain what are you trying to do?

@RealHinome RealHinome Jun 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not do the same thing. wait_until_succeeds is used as a readiness barrier, not as the final assertion. portail.service being active and listening on port 8080 does not guarantee that the identity-aware upstream path is already usable.

We sometimes observe curl timeouts (exit code 28) in CI when the first proxied request happened too early (e.g. on latest commit, link), including in my PR CI.

This is currently a workaround to avoid the race condition. A better solution would be to have an explicit readiness signal from portail once the identity-aware upstream path is fully ready.

"curl --fail --silent --output /dev/null --max-time 5 --proxy http://127.0.0.1:8080 https://hello.corp.example.com",
timeout=30
)

# Test HTTP CONNECT curl -> portail -(TLS)-> portail (hop) -> corp-server
result = json.loads(node.succeed(
"curl --fail --max-time 5 --proxy http://127.0.0.1:8080 https://hello.corp.example.com"
Expand Down