Add SubscribeEvents to enable user notifications - #186
Merged
Merged
Conversation
Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
rlahfa-dinum
commented
Sep 3, 2026
rlahfa-dinum
force-pushed
the
user-notifications
branch
from
September 3, 2026 12:01
07d7ddb to
a2f2e98
Compare
agrimault-dinum
approved these changes
Sep 4, 2026
agrimault-dinum
left a comment
agrimault-dinum
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, you already pointed out the unimplemented event fields
SubscribeEvents is a stream, therefore, it uses the `more` annotation. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
We use a bus with 2048 events, this is certainly well enough. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
Useful for debugging and small scripting. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
RPC subsystems now also use the Arc<ProxyRuntime> pointer, this avoids locking the state needlessly as the broadcaster is itself properly protected. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
We also use tr! to translate the strings in the future. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
This adds a very simple setup for i18n using the tr crate and include-po. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
The project has grown complicated enough so that nix-shell -p doesn't cut it anymore. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
rlahfa-dinum
force-pushed
the
user-notifications
branch
from
September 7, 2026 11:52
a2f2e98 to
7e1cfe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the infrastructure to broadcast events inside the program and let someone subscribe via RPC.
Additionally, Portail gains i18n features to support translation of user-facing messages.
I only added one emit for now, but I will add more in this PR: SOCKS5 & pre-handshake. HTTP CONNECT will use the future error pages mechanism rather.
Signed-off-by: Ryan Lahfa ryan.lahfa.ext@numerique.gouv.fr