Conversation
Nothing after the disk-mount check checked its own exit status, so a failing nixos-install (or Secure Boot enrollment, or key provisioning) still ended with "Installation is complete." Wraps that section in a subshell with set -e and checks its exit code before reporting success; the install log is still saved to the target disk either way.
T2an
requested review from
jdauphant-dinum,
olebrouster-dinum,
plegrand-dinum and
rlahfa-dinum
as code owners
September 22, 2026 09:21
rlahfa-dinum
approved these changes
Sep 22, 2026
rlahfa-dinum
added
the
status: awaiting smoke testing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped into "Installation is complete. You can now reboot in the installed system." after a failed install.
Nothing after the disk-mount check checked its own exit status, so a failing nixos-install (or Secure Boot enrollment, or key provisioning) still ended with "Installation is complete." Wraps that section in a subshell with set -e and checks its exit code before reporting success. The install log is still saved to the target disk either way.