Fix debian PackageCloud upload#237
Merged
viktorerlingsson merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
The commit c979e4c changed the build output directory structure from builds/ubuntu/jammy/*.deb to builds/linux_amd64/*.deb. The PackageCloud upload script was still trying to extract distribution info from the file path, resulting in empty DIST_ID values and 422 errors. This fix extracts the distribution ID and version codename from the matrix.os variable instead (e.g., "ubuntu-jammy" → "ubuntu" + "jammy"), matching the pattern already used successfully in the RPM section.
baelter
approved these changes
Jan 15, 2026
|
FYI, I think this broke some packages for Debian systems, see #236 (comment). Looks like the Bullseye package for instance, was not built on a Bullseye system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit c979e4c changed the build output directory structure from builds/ubuntu/jammy/.deb to builds/linux_amd64/.deb. The PackageCloud upload script was still trying to extract distribution info from the file path, resulting in empty DIST_ID values and 422 errors.
This fix extracts the distribution ID and version codename from the matrix.os variable instead (e.g., "ubuntu-jammy" → "ubuntu" + "jammy"), matching the pattern already used successfully in the RPM section.
Fixes #236