This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Fix inconsistent enum constant names between schema and serialization#181
Open
clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
Open
Fix inconsistent enum constant names between schema and serialization#181clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
Conversation
- param and resource de/serialization uses Jackson configuration - schema generation used Enum.name(), should use Jackson instead
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
============================================
+ Coverage 80.06% 80.09% +0.03%
Complexity 1715 1715
============================================
Files 159 159
Lines 5718 5727 +9
Branches 754 753 -1
============================================
+ Hits 4578 4587 +9
Misses 856 856
Partials 284 284
Continue to review full report at Codecov.
|
alarribeau
approved these changes
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
============================================
+ Coverage 80.06% 80.09% +0.03%
Complexity 1715 1715
============================================
Files 159 159
Lines 5718 5727 +9
Branches 754 753 -1
============================================
+ Hits 4578 4587 +9
Misses 856 856
Partials 284 284
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case: Having custom @JsonProperty("enumValue") on enum constants is useful when implementing an API with param values that are not valid Java identifiers (for example, with dots).
Note: the new method Types.getEnumValuesAndDescriptions might not be at an ideal location, but I could not find a better place to extract it.