This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Add extra fields in ServiceException#182
Open
llbrt wants to merge 1 commit intocloudendpoints:masterfrom
Open
Conversation
- may enhance ServiceException with extra fields - limit values to simple objects (nor array nor collection) - add extra fields in error body - add unit tests - note: add test dependency to JSONassert, license Apache 2.0
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
============================================
+ Coverage 80.06% 80.24% +0.17%
- Complexity 1715 1721 +6
============================================
Files 159 159
Lines 5718 5734 +16
Branches 754 757 +3
============================================
+ Hits 4578 4601 +23
+ Misses 856 849 -7
Partials 284 284
Continue to review full report at Codecov.
|
alarribeau
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of these changes is to be able to add some extra fields in ServiceException, to give more details about the error. These fields may be documented by the service and used on the client side (diagnosis, help, ...).
For example, the field 'extendedHelp' in this reply