Skip to content

⚡ Bolt: [performance improvement] Avoid deep cloning Serde intermediate Values#47

Draft
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt-avoid-deep-clone-serde-3844345141445516271
Draft

⚡ Bolt: [performance improvement] Avoid deep cloning Serde intermediate Values#47
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt-avoid-deep-clone-serde-3844345141445516271

Conversation

@cloudesize67-cmd
Copy link
Copy Markdown
Owner

💡 What
Replaced serde_json::from_value::<T>(val.clone()) and serde_yaml::from_value::<T>(val.clone()) with T::deserialize(val) in xdk-openapi/src/parser.rs for intermediate node parsing.

🎯 Why
When parsing sections of the OpenAPI spec before deserializing the entire document, calling from_value on a clone of the Value node deep-copies the entire intermediate dynamic object tree (allocating new arrays, objects, and strings). Using T::deserialize(&val) bypasses this clone by directly consuming the reference to the Value tree.

📊 Impact
Eliminates significant memory allocation and deep cloning during the first pass of OpenAPI component extraction. Should reduce overall parsing times for large OpenAPI specs.

🔬 Measurement
Verified functionality is unchanged with make test-generator. The performance difference can be seen when parsing extremely large specs containing massive schemas and components.


PR created automatically by Jules for task 3844345141445516271 started by @cloudesize67-cmd

…ate Values

Co-authored-by: cloudesize67-cmd <237356855+cloudesize67-cmd@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant