⚡ Bolt: [performance improvement] Avoid deep cloning Serde intermediate Values#47
⚡ Bolt: [performance improvement] Avoid deep cloning Serde intermediate Values#47cloudesize67-cmd wants to merge 1 commit into
Conversation
…ate Values Co-authored-by: cloudesize67-cmd <237356855+cloudesize67-cmd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Replaced
serde_json::from_value::<T>(val.clone())andserde_yaml::from_value::<T>(val.clone())withT::deserialize(val)inxdk-openapi/src/parser.rsfor intermediate node parsing.🎯 Why
When parsing sections of the OpenAPI spec before deserializing the entire document, calling
from_valueon a clone of theValuenode deep-copies the entire intermediate dynamic object tree (allocating new arrays, objects, and strings). UsingT::deserialize(&val)bypasses this clone by directly consuming the reference to theValuetree.📊 Impact
Eliminates significant memory allocation and deep cloning during the first pass of OpenAPI component extraction. Should reduce overall parsing times for large OpenAPI specs.
🔬 Measurement
Verified functionality is unchanged with
make test-generator. The performance difference can be seen when parsing extremely large specs containing massive schemas and components.PR created automatically by Jules for task 3844345141445516271 started by @cloudesize67-cmd