Skip to content

⚡ Bolt: [performance improvement] Eliminate expensive Serde deep clones in OpenAPI parser#53

Draft
cloudesize67-cmd wants to merge 1 commit into
mainfrom
jules-3379428395105184383-d6258eca
Draft

⚡ Bolt: [performance improvement] Eliminate expensive Serde deep clones in OpenAPI parser#53
cloudesize67-cmd wants to merge 1 commit into
mainfrom
jules-3379428395105184383-d6258eca

Conversation

@cloudesize67-cmd
Copy link
Copy Markdown
Owner

💡 What: Replaced intermediate variable cloning in xdk-openapi/src/parser.rs with ::deserialize(val) to avoid serde_yaml::from_value(val.clone()) overhead.
🎯 Why: Deep cloning serde_json::Value and serde_yaml::Value constructs (which contains nested HashMaps and Vecs representing OpenAPI specifications) just to deserialize it is very slow and wastes memory.
📊 Impact: Directly deserializing from references significantly speeds up the SDK generation for large API schema, eliminating unnecessary intermediate object allocations.
🔬 Measurement: Verify changes via cargo test and make check suites. Code correctly resolves without deep clones.


PR created automatically by Jules for task 3379428395105184383 started by @cloudesize67-cmd

…es in OpenAPI parser

Co-authored-by: cloudesize67-cmd <237356855+cloudesize67-cmd@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant