Skip to content

⚡ Bolt: [performance improvement] Optimize stdout parsing by removing intermediate allocations #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cloudesize67-cmd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: [performance improvement] Optimize stdout parsing by removing intermediate allocations #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions xdk-build/src/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,13 @@ fn run_formatter(output_dir: &Path, venv_python_path: &Path, script_path: &Path)
let stdout = String::from_utf8_lossy(&output.stdout);
if !stdout.trim().is_empty() {
println!();
stdout
.split("\n")
.collect::<Vec<&str>>()
.into_iter()
.for_each(|line| {
let parts = line.split(" ").collect::<Vec<&str>>();
if parts.len() == 2 {
log_info!("{} {}", parts[0], parts[1].magenta());
}
});
// Optimization: Use character-based split and pattern matching to avoid intermediate Vec allocations
stdout.split('\n').for_each(|line| {
let mut parts = line.split(' ');
if let (Some(part0), Some(part1), None) = (parts.next(), parts.next(), parts.next()) {
log_info!("{} {}", part0, part1.magenta());
}
});
println!();
}

Expand Down
Loading