fix: websocket session and callback promise retention leak#154
Open
VastBlast wants to merge 3 commits intocloudflare:mainfrom
Open
fix: websocket session and callback promise retention leak#154VastBlast wants to merge 3 commits intocloudflare:mainfrom
VastBlast wants to merge 3 commits intocloudflare:mainfrom
Conversation
|
…ancellation without delaying cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #153, a client-side memory leak in long-lived RPC sessions.
The session read loop was racing each
transport.receive()call against a single session-long abort promise, which causedPromise.race()to accumulate until the entire session was disposed. This changesRpcSessionto use a fresh cancellation promise for each pending read.Edit: I also noticed another issue with callbacks causing a memory leak which isn't specifically reproduced in #153 which has been patched in this PR too.
Essentially if you had something like this where the callback is called regularly:
The client would subscribe and capnweb would keep the callback promises in memory even though the result cannot be used.