add xlsx export suppport to workspace-sheets blueprint by maxwellpeterson · Pull Request #433 · cloudflare/cloudflare-os

maxwellpeterson · 2026-09-03T01:22:45Z

update built-in sheets blueprint to support xlsx export

github-actions · 2026-09-03T01:24:55Z

Preview: `pr433-mpeterson-xlsx-export`

https://pr433-mpeterson-xlsx-export-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

ask-bonk · 2026-09-03T01:34:09Z

Findings

Medium xlsx.js:361: Cells outside declared rows/cols are silently omitted, although the server accepts and persists them and CSV exports them. Export all valid Excel references or reject/prune them when stored.
Medium xlsx.js:463: nf: "text" converts formulas to literal strings. The app evaluates formulas independently of number formatting, so XLSX export changes workbook behavior.
Medium xlsx.js:385: Each unmatched apostrophe rescans the remaining formula, producing quadratic work. Valid 8,192-character cells can exceed the 30-second export deadline with only a few hundred formulas. Parse quoted references in one pass.

github run

ask-bonk · 2026-09-03T04:17:28Z

@maxwellpeterson Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

ask-bonk · 2026-09-03T04:29:31Z

Submitted one review with 3 actionable inline findings.

github run

ask-bonk · 2026-09-03T06:16:30Z

Submitted one review with 3 actionable inline findings.

github run

ask-bonk · 2026-09-03T19:07:00Z

Submitted one review with 2 actionable inline findings. Focused XLSX tests pass (24/24).

github run

ask-bonk · 2026-09-03T21:12:06Z

Submitted one review with 3 actionable inline findings.

github run

ask-bonk · 2026-09-03T21:31:49Z

+  if (cell.value === "") return `<c r="${cell.reference}"${style}/>`;
+  const parsed = parsedCellValue(cell.value, formulaNames);
+  if (parsed.type === "blank") return `<c r="${cell.reference}"${style}/>`;
+  if (parsed.type === "formula") return `<c r="${cell.reference}"${style}><f>${formulaXml(parsed.value)}</f></c>`;


client.js discards whitespace while tokenizing, so =SUM (1,2) is supported and evaluates to 3. This emits it verbatim as <f>SUM (1,2)</f>, but OOXML function-call syntax requires SUM to be immediately followed by its parameter list (a space is the reference-intersection operator), making the exported formula invalid when Excel recalculates it. Normalize function-call whitespace before emission, or export formulas with this app-only syntax as text.

ask-bonk · 2026-09-03T21:35:45Z

Submitted 1 inline finding. Additional findings:

High server.js:102: Delayed broadcasts can overwrite a sender’s newer local state, while its own corrective event is ignored.
Medium xlsx.js:549: =2^3^2 changes from 512 locally to 64 in Excel due to associativity differences.
Medium xlsx.js:252: Font sizes are stored/rendered as pixels but exported as points, making custom fonts about 33% larger.

github run

github-actions · 2026-09-04T23:15:48Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

ask-bonk · 2026-09-04T23:33:13Z

Findings

Medium xlsx.js:531: Malformed formulas accepted by the grid, such as =SUM(1,2 or ="abc, are emitted as invalid Excel formulas. Validate them or export as text.
Medium xlsx.js:531: Out-of-grid references remain formulas despite their cells being omitted. For example, =XFE1+1 evaluates locally but becomes #NAME? in Excel.

Focused tests pass (23/23).

github run

…king and dispose dropped stubs

ask-bonk · 2026-09-04T23:52:32Z

Findings

Medium xlsx.js:456: Names requiring Excel delimiters, such as R1C1 or $Data, remain unquoted, breaking cross-sheet formulas. Quote unchanged names when required.
Medium xlsx.js:311: Date serial 1 displays 12/31/1899 locally but 01/01/1900 in Excel due to incompatible epochs.
Medium xlsx.js:303: Integer formatting changes -1.5 from -1 locally to -2 in Excel because rounding semantics differ.

github run

devin-ai-integration

Devin Review found 1 new potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

devin-ai-integration · 2026-09-04T23:55:33Z

+    return this.enqueueMutation(async () => {
+      const document = await this.assembleDocument(await this.loadMeta());


🟡 Failed subscriptions leak callback capabilities

When snapshot assembly fails, subscribe abandons the duplicated callback before registration. The caller gets an error, but its server capability remains allocated.

Prompt for agents

In packages/workshop-backend/format-blueprints/workspace-sheets/files/server.js, Gadget.subscribe duplicates the callback before enqueueing snapshot assembly. If loadMeta or assembleDocument rejects, the duplicate was never added to subscribers, so dropSubscriber cannot release it. Ensure every failure before successful registration disposes dup exactly once, while preserving the queued snapshot-and-registration ordering and the existing onRpcBroken cleanup.

Was this helpful? React with 👍 or 👎 to provide feedback.

add xlsx export suppport to workspace-sheets blueprint

a9e1bb4

github-actions Bot added the kernel Changes to the Workshop kernel label Sep 3, 2026

maxwellpeterson marked this pull request as ready for review September 3, 2026 03:11