Skip to content

fix: preserve custom resource URL schemes - #451

Open
atirna wants to merge 1 commit into
cloudflare:mainfrom
atirna:fix/preserve-resource-url-schemes
Open

fix: preserve custom resource URL schemes#451
atirna wants to merge 1 commit into
cloudflare:mainfrom
atirna:fix/preserve-resource-url-schemes

Conversation

@atirna

@atirna atirna commented Sep 5, 2026

Copy link
Copy Markdown

What does this change?

normalizeResourceUrl() now preserves resource URLs with a custom scheme:// prefix instead of prepending https://. Bare resource hosts still receive the existing HTTPS default, and trailing /* is still removed.

Fixes #390

Why is this obviously correct and trivially verifiable?

The one shared normalizer now recognizes the URL scheme form already used by custom resource patterns. Its existing default only applies when that prefix is absent. The focused test covers both the reported gitlab:// path and the bare-host default.

Checklist

  • This is a small, concrete change; it is not a feature, refactor, or low-value cleanup.
  • I understand that maintainers decide whether the change is obviously correct and trivially verifiable.
  • I have read and followed the contribution guidelines.

Devin Review

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot added the workshop/frontend Changes to the Workshop frontend label Sep 5, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@atirna

atirna commented Sep 5, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workshop/frontend Changes to the Workshop frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

normalizeResourceUrl mangles custom-scheme resource URLs (gitlab://x → https://gitlab://x)

1 participant