fix: preserve custom resource URL schemes - #451
Open
atirna wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
normalizeResourceUrl()now preserves resource URLs with a customscheme://prefix instead of prependinghttps://. Bare resource hosts still receive the existing HTTPS default, and trailing/*is still removed.Fixes #390
Why is this obviously correct and trivially verifiable?
The one shared normalizer now recognizes the URL scheme form already used by custom resource patterns. Its existing default only applies when that prefix is absent. The focused test covers both the reported
gitlab://path and the bare-host default.Checklist