Skip to content

Make Gardener triage verify against current code and fix decisively - #267

Merged
scuffi merged 1 commit into
mainfrom
gardener-triage-depth
Oct 22, 2026
Merged

scuffi merged 1 commit into
mainfrom
gardener-triage-depth

Conversation

@scuffi

@scuffi scuffi commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Tightens the Gardener triage and fix prompts after the first manual test runs.

triage

  • Verifies every issue against the current code before judging: it reads the files concerned (not code search, which is rate-limited), traces the behaviour, confirms the problem exists today, and checks related issues and PRs. If it can't find the problem, the issue is treated as not actionable.
  • Its comment cites the code it checked as path:line, and its run summary lists the files it read.
  • Picks the best fix itself instead of handing a decision to a maintainer. High-cost issues get a recommended fix and the alternatives it ruled out, plus the gardener-fix pointer.
  • Low impact, low cost: label only, no comment.
  • Assigns by numeric user id. In testing, two assignments by login were refused.

fix

  • Reproduces the problem first with a failing test on the default branch. If it can't, it opens nothing and comments with what it found.
  • Builds the best fix rather than the smallest, and decides itself.
  • The PR body explains the cause, why this option, the alternatives considered and the checks run. It ends by noting that a maintainer can mention @gardener-cf on the PR to switch to an alternative or ask for changes.

Triage still runs automatically only on @scuffi's issues and manual runs until the cutover.


Devin Review

@scuffi scuffi added the allow-pr Allow a PR to remain open. label Oct 22, 2026
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 08a30da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

2. Act on the result:
1. Verify it against the current code on the default branch. Never take the report on trust: find
the code it concerns with `repository.list_files` and `repository.read_file` (code search is
rate-limited, so don't rely on it), trace the behaviour it describes, and confirm the problem

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 British spelling in triage instructions

The new triage instruction uses behaviour, contrary to the repository's American English prose rule.

Suggested change
rate-limited, so don't rely on it), trace the behaviour it describes, and confirm the problem
rate-limited, so don't rely on it), trace the behavior it describes, and confirm the problem

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@cloudflare/computer@267

commit: 08a30da

@scuffi
scuffi merged commit 07d483c into main Oct 22, 2026
28 checks passed
@scuffi
scuffi deleted the gardener-triage-depth branch October 22, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-pr Allow a PR to remain open.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant