Skip to content

fix linter issues #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
third774 merged 1 commit into from
Oct 17, 2025
Merged

fix linter issues #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
node_modules
.wrangler
/.cache
/build
/dist
/public/build
/.mf
playwright-report
test-results
public/e2ee/
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
public/mockServiceWorker.js
public/e2ee/wasm-pkg/
2 changes: 1 addition & 1 deletion app/hooks/usePulledVideoTrack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function usePulledVideoTrack(
: of(undefined)
)
),
[partyTracks, trackObject$, preferredRid$]
[trackObject$, partyTracks, simulcastEnabled, preferredRid$]
)
return useObservableAsValue(pulledTrack$)
}
2 changes: 1 addition & 1 deletion app/hooks/useRoomHistory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function useRoomHistory(
return () => {
partyTracks.history.removeEventListener('logentry', handleHistory)
}
}, [partyTracks, sessionId])
}, [partyTracks, room.websocket, sessionId])

useEffect(() => {
room.otherUsers.forEach((user) => {
Expand Down
2 changes: 1 addition & 1 deletion app/hooks/useStageManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function useStageManager(
setPinnedTileIds((ids) => [...ids, user.id])
}
})
}, [newUsers, recordActivity])
}, [newUsers, recordActivity, setPinnedTileIds])

useEffect(() => {
setActorsOnStage((actorsAlreadyOnStage) =>
Expand Down
1 change: 1 addition & 0 deletions app/utils/safeReturnUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { redirect } from '@remix-run/cloudflare'

export function safeRedirect(url: string, init?: number | ResponseInit) {
if (
// eslint-disable-next-line no-script-url
['javascript:', 'data:', 'vbscript:'].some((str) =>
decodeURI(url).trim().toLowerCase().startsWith(str)
)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"scripts": {
"build": "remix build",
"build:e2ee-worker": "./rust-mls-worker/build.sh",
"lint": "prettier --check . && eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint --max-warnings=0 .",
"lint": "prettier --check . && eslint --cache --cache-location ./node_modules/.cache/eslint --max-warnings=0 .",
"dev": "remix dev --manual -c \"npm start\"",
"start": "wrangler dev ./build/index.js ${WRANGLER_ARGS:-}",
"prebuild": "npm run clean",
Expand Down