Fix non http promtail config add spec tests - #26
Open
jorbaum wants to merge 2 commits into
Open
Conversation
jorbaum
commented
Aug 11, 2025
Contributor
Author
|
@ZPascal can you take a look at it? |
There was a problem hiding this comment.
Pull request overview
Fixes the promtail Loki client URL scheme selection (http vs https) in the BOSH template and adds an RSpec-based spec test + CI workflow to validate the rendered config.
Changes:
- Correct the promtail Loki client URL to use
http://when TLS/mTLS is disabled. - Add an RSpec test verifying the rendered Loki client URL scheme.
- Add Ruby/Bundler setup (Gemfile/lock), a spec-test script, and a GitHub Actions workflow to run the specs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
jobs/promtail/templates/config/config.yml.erb |
Fixes URL scheme logic for the Loki client endpoint. |
spec/jobs/promtail_spec.rb |
Adds spec coverage for http vs https Loki client URL rendering. |
scripts/subtests/spec-test |
Adds a script entrypoint for running the spec suite via bundler. |
Gemfile |
Introduces Ruby dependencies needed for spec testing. |
Gemfile.lock |
Locks Ruby dependency versions for reproducible CI runs. |
.github/workflows/scripts.yml |
Runs the spec-test script on PRs/pushes to main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZPascal
requested changes
Mar 31, 2026
Collaborator
Start with promtail config file for now. Based on https://github.com/cloudfoundry/otel-collector-release
jorbaum
force-pushed
the
fix-non-http-promtail-config-add-spec-tests
branch
from
July 15, 2026 11:23
cc0e133 to
ed3d25d
Compare
Contributor
Author
Updated :) . I addressed all comments from you and copilot. One of copilot's suggestions was slightly off, besides that all valid comments and should all be worked in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly fixes a minor typo.
While I was at it I also added some tests and GitHub workflow for it based on
https://github.com/cloudfoundry/otel-collector-release
Only the two properties of the promtail config file are being tested for now.