Skip to content

Conversation

@SaifuddinMerchant
Copy link
Contributor

No description provided.

@SaifuddinMerchant
Copy link
Contributor Author

This PR would supersede #1297

Copy link
Contributor

@Kehrlann Kehrlann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Have you tested this against a CF deployment?

Please consider adding an integration test for creating a user by username + origin.


this.cloudFoundryClient
.usersV3()
.create(CreateUserRequest.builder().userId(userId).build())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if the GUID does not match that of a UAA user?

Comment on lines +44 to +46
/**
* Origin of the user to be created. This can only be provided together with username and cannot be uaa.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of error do we get from CAPI if username is provided with userId ; or without origin? What if we pass the uaa origin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants