Skip to content

Improve service instance type matching #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samze merged 1 commit into from
Aug 22, 2025
Merged

Improve service instance type matching #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/cf/latest/components/schemas/Job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ allOf:
manifest:
$ref: './Link.yaml'
description: The URL to get the manifest for this job
service_broker:
service_brokers:
$ref: './Link.yaml'
description: The URL to get the service broker for this job
service_credential_binding:
$ref: './Link.yaml'
description: The URL to get the service credential binding for this job
service_instance:
service_instances:
$ref: './Link.yaml'
description: The URL to get the service instance for this job
service_route_binding:
service_route_bindings:
$ref: './Link.yaml'
description: The URL to get the service route binding for this job
description: 'Jobs are created by the platform when performing certain asynchronous actions. Asynchronous jobs are commonly used for long-running tasks such as uploading large files, staging applications, or deleting resources.'
5 changes: 5 additions & 0 deletions apis/cf/latest/components/schemas/ServiceCredentialBindingList.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@ properties:
oneOf:
- $ref: './AppCredentialBinding.yaml'
- $ref: './KeyCredentialBinding.yaml'
discriminator:
propertyName: type
mapping:
app: './AppCredentialBinding.yaml'
key: './KeyCredentialBinding.yaml'
5 changes: 5 additions & 0 deletions apis/cf/latest/components/schemas/ServiceInstanceList.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@ properties:
oneOf:
- $ref: './ManagedServiceInstance.yaml'
- $ref: './UserProvidedServiceInstance.yaml'
discriminator:
propertyName: type
mapping:
managed: './ManagedServiceInstance.yaml'
user-provided: './UserProvidedServiceInstance.yaml'
5 changes: 2 additions & 3 deletions apis/cf/latest/components/schemas/UserProvidedServiceInstance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ properties:
type: string
format: uri
description: URL for route service
credentials:
type: object
description: Service credentials
relationships:
type: object
properties:
Expand All @@ -53,6 +50,8 @@ properties:
$ref: './Link.yaml'
service_route_bindings:
$ref: './Link.yaml'
credentials:
$ref: './Link.yaml'
metadata:
$ref: './Metadata.yaml'
required:
Expand Down
15 changes: 15 additions & 0 deletions apis/cf/latest/paths/ServiceCredentialBindings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@
oneOf:
- $ref: ../components/schemas/AppCredentialBinding.yaml
- $ref: ../components/schemas/KeyCredentialBinding.yaml
discriminator:
propertyName: type
mapping:
app: '../components/schemas/AppCredentialBinding.yaml'
key: '../components/schemas/KeyCredentialBinding.yaml'
'202':
description: Accepted
headers:
Expand Down Expand Up @@ -160,6 +165,11 @@
oneOf:
- $ref: ../components/schemas/AppCredentialBinding.yaml
- $ref: ../components/schemas/KeyCredentialBinding.yaml
discriminator:
propertyName: type
mapping:
app: '../components/schemas/AppCredentialBinding.yaml'
key: '../components/schemas/KeyCredentialBinding.yaml'
links:
app:
operationId: getApp
Expand Down Expand Up @@ -194,6 +204,11 @@
oneOf:
- $ref: ../components/schemas/AppCredentialBinding.yaml
- $ref: ../components/schemas/KeyCredentialBinding.yaml
discriminator:
propertyName: type
mapping:
app: '../components/schemas/AppCredentialBinding.yaml'
key: '../components/schemas/KeyCredentialBinding.yaml'
'401':
$ref: '../components/responses/Unauthorized.yaml'
'404':
Expand Down
10 changes: 10 additions & 0 deletions apis/cf/latest/paths/ServiceInstances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,11 @@
oneOf:
- $ref: ../components/schemas/ManagedServiceInstance.yaml
- $ref: ../components/schemas/UserProvidedServiceInstance.yaml
discriminator:
propertyName: type
mapping:
managed: '../components/schemas/ManagedServiceInstance.yaml'
user-provided: '../components/schemas/UserProvidedServiceInstance.yaml'
links:
space:
operationId: getSpace
Expand Down Expand Up @@ -332,6 +337,11 @@
oneOf:
- $ref: ../components/schemas/ManagedServiceInstance.yaml
- $ref: ../components/schemas/UserProvidedServiceInstance.yaml
discriminator:
propertyName: type
mapping:
managed: '../components/schemas/ManagedServiceInstance.yaml'
user-provided: '../components/schemas/UserProvidedServiceInstance.yaml'
links:
space:
operationId: getSpace
Expand Down