Skip to content

Improve spec and compliance testing - #1027

Merged
Samze merged 5 commits into
mainfrom
improve-spec
Aug 22, 2025
Merged

Improve spec and compliance testing#1027
Samze merged 5 commits into
mainfrom
improve-spec

Conversation

@FloThinksPi

Copy link
Copy Markdown
Member

No description provided.

parameters:
- $ref: '../components/parameters/Guid.yaml'
responses:
'201':

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about some of these results from wiretap, I don't see how CC returned 201 for a space delete

https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/controllers/v3/spaces_controller.rb#L96

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True could it be https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/controllers/v3/spaces_controller.rb#L64 ? May have to remove it back to 200 and look what the tests say. Curious as well.

Comment thread bin/build.js
try {
let content = await fs.readFile(outputFile, 'utf8');

// Fix references that still point to external files

@Samze Samze Aug 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these references are not resolved because they are placed in not valid parts of the openapi tree. So I think we can just fix those up rather than do this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md
schema:
type: string
responses:
'201':

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@Samze
Samze merged commit 3318cc0 into main Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants