Skip to content

Exclude unsupported windows/arm from goreleaser build matrix - #2133

Merged
Andriy Knysh (aknysh) merged 2 commits into
mainfrom
goruha/update-goreleaser
Mar 3, 2026
Merged

Andriy Knysh (aknysh) merged 2 commits into
mainfrom
goruha/update-goreleaser

Conversation

@goruha

@goruha Igor Rodionov (goruha) commented Mar 3, 2026 •

Copy link
Copy Markdown
Member

what

  • Add ignore rule to the shared goreleaser config (.github/goreleaser.yml) to exclude the windows/arm (32-bit ARM) build target
  • Prevents "unsupported GOOS/GOARCH pair windows/arm" build failures for any org repo using Go 1.24+

why

  • Go 1.24 (February 2025) deprecated the windows/arm port, and Go 1.25+ removed it entirely. Any repo that upgrades past Go 1.23 and uses this shared goreleaser config will fail during the release build after spending ~33 minutes compiling the other 13 targets
  • The ignore rule is harmless for repos still on Go < 1.24 — goreleaser simply skips a target that would otherwise build successfully. No binaries are lost for any currently-supported platform
  • windows/arm (32-bit ARM on Windows) had negligible real-world usage — Windows on ARM devices run 64-bit Windows 11 (windows/arm64), which remains supported

references

Summary by CodeRabbit

  • Chores
    • Excluded Windows ARM 32-bit builds from release distribution.

@goruha
Igor Rodionov (goruha) requested a review from a team as a code owner March 3, 2026 19:00
@github-actions github-actions Bot added the size/xs Extra small size PR label Mar 3, 2026
@mergify mergify Bot added the triage Needs triage label Mar 3, 2026
@github-actions

github-actions Bot commented Mar 3, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@mergify mergify Bot removed the triage Needs triage label Mar 3, 2026
@coderabbitai

coderabbitai Bot commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8e95b5b and aac6f7f.

📒 Files selected for processing (1)
  • .goreleaser.yml

📝 Walkthrough

Walkthrough

The PR adds an ignore configuration to .goreleaser.yml to exclude Windows ARM 32-bit builds from release artifacts, addressing Go 1.24+ dropping support for this platform combination.

Changes

Cohort / File(s) Summary
GoReleaser Build Configuration
.goreleaser.yml
Added ignore section under builds to explicitly exclude Windows on ARM (32-bit) targets from release builds due to Go 1.24+ platform support changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

patch

Suggested reviewers

  • osterman
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: excluding the unsupported windows/arm target from the GoReleaser build matrix, matching the core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch goruha/update-goreleaser

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aknysh Andriy Knysh (aknysh) added the no-release Do not create a new release (wait for additional code changes) label Mar 3, 2026
@aknysh
Andriy Knysh (aknysh) merged commit 53d7820 into main Mar 3, 2026
130 of 141 checks passed
@aknysh
Andriy Knysh (aknysh) deleted the goruha/update-goreleaser branch March 3, 2026 20:22
@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.55%. Comparing base (8e95b5b) to head (aac6f7f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   76.54%   76.55%           
=======================================
  Files         832      832           
  Lines       79458    79458           
=======================================
+ Hits        60824    60830    +6     
+ Misses      14841    14836    -5     
+ Partials     3793     3792    -1     
Flag Coverage Δ
unittests 76.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

These changes were released in v1.208.0.

Igor Rodionov (goruha) added a commit that referenced this pull request Mar 9, 2026
…raform-plan

* osterman/native-ci-terraform: (28 commits)
  feat: Add source cache TTL for JIT-vendored components (#2138)
  feat: Per-target version overrides in vendor manifests (#2141)
  docs: Add PRD for browser-based auth in aws/user identity (#1887)
  docs: Add EKS kubeconfig authentication integration PRD (#1884)
  fix: correct marketplace.json schema and update docs with install/uninstall commands (#2142)
  fix: propagate auth to all YAML functions in multi-component execution (#2140)
  fix: Use atmos_component for source provisioner workdir paths (#2137)
  Fix identity prompts to respect --interactive flag (#2130)
  Increase PR size thresholds to accommodate AI-assisted development (#2136)
  docs: Add Azure authentication provider documentation (#2132)
  fix: propagate component-type level dependencies through stack processor (#2127)
  fix: Add retry and missing workflow step properties to all schema copies (#2113)
  Exclude unsupported windows/arm from goreleaser build matrix (#2133)
  Add AI Agent Skills for LLM-Powered Infrastructure Development (#2121)
  Fix: Convert toolchain paths to absolute in PATH to resolve exec.LookPath failures (#2095)
  Fix workdir collision for component instances sharing base component (#2093)
  fix(auth): propagate TTY state to subprocesses for SSO device flow in workflows (#2126)
  fix(security): prevent SSRF in GitHub OIDC token URL handling (CWE-918) (#2106)
  Fix #2112: add workflow_retry definition and retry property to workflow step schema (#2114)
  fix(auth): auto-detect GitHub Actions WIF with proper audience, host validation, and lazy GSM init (#2109)
  ...
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown

These changes were released in v1.208.1-test.9.

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown

These changes were released in v1.208.1-test.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) size/xs Extra small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants