Repository navigation
chore: remove approvers team from CODEOWNERS requirements - #2938
Erik Osterman (Cloud Posse) (osterman) merged 3 commits into
Conversation
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CODEOWNERS rules for Terraform and documentation files now assign review ownership only to engineering. ChangesReview ownership rules
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This narrowly changes review ownership requirements so engineering approval is sufficient for the listed files; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
==========================================
- Coverage 83.42% 83.41% -0.01%
==========================================
Files 1909 1909
Lines 186868 186868
==========================================
- Hits 155891 155881 -10
- Misses 23066 23078 +12
+ Partials 7911 7909 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
These changes were released in v1.226.0-test.13. |
…into 1199-pro-exec-metadata * '1199-pro-exec-metadata' of github.com:cloudposse/atmos: ci(test): shard acceptance tests 10-way per OS to cut CI runtime (#2940) chore: remove approvers team from CODEOWNERS requirements (#2938) fix(schema): model required_providers/retry/Helm in atmos-manifest (#2950)
what
@cloudposse/approversas a required owner from.github/CODEOWNERS— the four patternsthat listed it (
**/*.tf,README.yaml,README.md,docs/*.md) now require only@cloudposse/engineeringwhy
require_code_owner_reviewenforced, any PR touching a matching file demands an approvalfrom the
approversteam in addition to engineering review. The bareREADME.mdpattern matchesREADMEs anywhere in the tree, so even CI-only changes (e.g. chore: upgrade actions to Node 24 runtime (SHA-pinned) #2934, which updates a README inside
.github/actions/) get blocked on the extra teamapproversrequirement so engineering review alone sufficesreferences