Skip to content

chore: remove approvers team from CODEOWNERS requirements - #2938

Merged
Erik Osterman (Cloud Posse) (osterman) merged 3 commits into
mainfrom
chore/remove-approvers-codeowners
Aug 19, 2026
Merged

Erik Osterman (Cloud Posse) (osterman) merged 3 commits into
mainfrom
chore/remove-approvers-codeowners

Conversation

@johncblandii

@johncblandii John C. Bland II (johncblandii) commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

what

  • Remove @cloudposse/approvers as a required owner from .github/CODEOWNERS — the four patterns
    that listed it (**/*.tf, README.yaml, README.md, docs/*.md) now require only
    @cloudposse/engineering

why

  • With require_code_owner_review enforced, any PR touching a matching file demands an approval
    from the approvers team in addition to engineering review. The bare README.md pattern matches
    READMEs anywhere in the tree, so even CI-only changes (e.g. chore: upgrade actions to Node 24 runtime (SHA-pinned) #2934, which updates a README inside
    .github/actions/) get blocked on the extra team
  • Requested by Erik: drop the approvers requirement so engineering review alone suffices

references

@johncblandii John C. Bland II (johncblandii) added the no-release Do not create a new release (wait for additional code changes) label Aug 14, 2026
Copilot AI lite review requested due to automatic review settings August 14, 2026 20:34
@atmos-pro

atmos-pro Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the size/xs Extra small size PR label Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify Bot added the needs-cloudposse Needs Cloud Posse assistance label Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bf15c783-7906-49ae-908a-bb92949d8f6a

📥 Commits

Reviewing files that changed from the base of the PR and between 498c376 and 5065198.

📒 Files selected for processing (1)
  • .github/CODEOWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/CODEOWNERS

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CODEOWNERS rules for Terraform and documentation files now assign review ownership only to engineering.

Changes

Review ownership rules

Layer / File(s) Summary
Update file ownership rules
.github/CODEOWNERS
Removes the approvers owner from Terraform, README.yaml, README.md, and docs/*.md patterns.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 50651

This narrowly changes review ownership requirements so engineering approval is sufficient for the listed files; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the approvers team from CODEOWNERS requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-approvers-codeowners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (498c376) to head (5065198).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
- Coverage   83.42%   83.41%   -0.01%     
==========================================
  Files        1909     1909              
  Lines      186868   186868              
==========================================
- Hits       155891   155881      -10     
- Misses      23066    23078      +12     
+ Partials     7911     7909       -2     
Flag Coverage Δ
unittests 83.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@atmos-pro

atmos-pro Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

Merged via the queue into main with commit 388baa0 Aug 19, 2026
80 of 81 checks passed
@osterman
Erik Osterman (Cloud Posse) (osterman) deleted the chore/remove-approvers-codeowners branch August 19, 2026 00:46
@atmos-pro

atmos-pro Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@mergify mergify Bot removed the needs-cloudposse Needs Cloud Posse assistance label Aug 19, 2026
@github-actions

Copy link
Copy Markdown

These changes were released in v1.226.0-test.13.

Igor Rodionov (goruha) added a commit that referenced this pull request Aug 19, 2026
…into 1199-pro-exec-metadata

* '1199-pro-exec-metadata' of github.com:cloudposse/atmos:
  ci(test): shard acceptance tests 10-way per OS to cut CI runtime (#2940)
  chore: remove approvers team from CODEOWNERS requirements (#2938)
  fix(schema): model required_providers/retry/Helm in atmos-manifest (#2950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) size/xs Extra small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants