Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
0185d32
feat(plugin): deliver Terragrunt log events live through the Atmos API
osterman Oct 31, 2026
50488ae
test(plugin): count only Atmos goroutines in the live-log cancellatio…
osterman Nov 1, 2026
9e5c1a3
test(plugin): verify concurrent log order and document retention
osterman Nov 11, 2026
3419f18
fix(sdk): cap live log batches at bridge limit
osterman Nov 11, 2026
c8c8494
fix(sdk): avoid replay after ambiguous log delivery
osterman Nov 11, 2026
fb7536e
test(sdk): assert exact cancellation omission count
osterman Nov 11, 2026
a0adb89
fix(plugin): identify rejected log batches
osterman Nov 11, 2026
da90b1b
test(plugin): isolate cancelled call goroutines
osterman Nov 11, 2026
8274064
test(terragrunt): fix streaming test gate setup
osterman Nov 11, 2026
0004353
docs(terragrunt): combine native support announcement
osterman Nov 13, 2026
13eac3e
test(terragrunt): bound and reap each streaming CLI run
osterman Nov 13, 2026
94e8677
fix(sdk): bound fallback logs by encoded response bytes
osterman Nov 13, 2026
f5cc919
fix(plugin): warn that queued logs may be lost on cancellation
osterman Nov 13, 2026
05bc0f8
Merge published Terragrunt integration into live logs
osterman Nov 13, 2026
adb945f
Merge latest published L8 base into Terragrunt live logs
osterman Nov 13, 2026
10fa05f
fix(tests): build streaming helper with plugin toolchain
osterman Nov 13, 2026
34728c2
fix(plugin): validate IAM probes independently of module preparation
osterman Nov 13, 2026
c3ff4c7
test: separate tool preconditions and clean acceptance lint policy
osterman Nov 13, 2026
3f277a4
test: simplify acceptance setup and preserve command errors
osterman Nov 13, 2026
924c93d
Merge published L8 source and backend fixes into live logs
osterman Nov 13, 2026
89bd2ce
Merge published L8 source subdirectory schema fix into L9
osterman Nov 13, 2026
394eda2
test: isolate CI error color expectations from terminal environment
osterman Nov 13, 2026
4b86168
test: honor configured timeout for short test suites
osterman Nov 13, 2026
91ea183
refactor(errors): organize sentinel declarations by domain
osterman Nov 13, 2026
2004bd1
refactor(errors): simplify formatting and Sentry configuration helpers
osterman Nov 13, 2026
f0ff59e
fix(container): isolate network alias test resources
osterman Nov 13, 2026
06070e2
Merge terragrunt native integration into live logs
osterman Nov 14, 2026
7f98508
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
32705c5
fix(errors): pass TERM into the terminal color decision
osterman Nov 14, 2026
52af727
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 14, 2026
c472027
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 14, 2026
21af588
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 14, 2026
0d63f3a
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 14, 2026
0ba29cf
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
6b46ac7
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
49b75e6
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
38924d9
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
b2779db
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 14, 2026
1149afa
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 15, 2026
3cc965f
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 15, 2026
ede7fc8
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 15, 2026
f37f837
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 16, 2026
0f99c5e
Merge branch 'feat/terragrunt-native-integration' into feat/terragrun…
osterman Nov 16, 2026
fd32eb0
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
8ff8ffb
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
b94e3f7
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
f601045
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
43ea09b
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
e3dfacd
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
c688a53
Merge remote-tracking branch 'origin/feat/terragrunt-native-integrati…
osterman Nov 16, 2026
a282f4b
fix(terragrunt): buffer unit paths until sensitive values are known
osterman Nov 17, 2026
31858b2
fix(terragrunt): document provider performance tracker boundary
osterman Nov 17, 2026
a3c4f0e
test(errors): isolate CI color assertion from inherited TERM
osterman Nov 17, 2026
4759471
Merge exact final L8 checkpoint into Terragrunt live logs
osterman Nov 17, 2026
4122a18
refactor(terragrunt): finish engine and provider lint baseline
osterman Nov 17, 2026
8c7f8f2
Merge published L8 consolidation into Terragrunt live logs
osterman Nov 17, 2026
d5e4911
fix(terragrunt): restore safe live evaluation progress
osterman Nov 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .atmos.d/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ commands:
- type: atmos
command: build deps
- type: shell
command: go test -short ${TEST:-$(go list ./...)} ${TESTARGS:-} -timeout 5m
command: go test -short ${TEST:-$(go list ./...)} ${TESTARGS:-} -timeout "${GO_TEST_TIMEOUT:-5m}"

- name: short-cover
description: Run quick tests with coverage
Expand All @@ -197,7 +197,7 @@ commands:
- type: atmos
command: build deps
- type: shell
command: go test -short -cover ${TEST:-$(go list ./...)} ${TESTARGS:-} -timeout 5m
command: go test -short -cover ${TEST:-$(go list ./...)} ${TESTARGS:-} -timeout "${GO_TEST_TIMEOUT:-5m}"

- name: coverage
description: Run tests with coverage report
Expand Down
3 changes: 3 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ linters:
provider-agnostic-auth:
files:
- "$all"
# Acceptance AWS credential checks and Floci SSM fixtures are AWS-specific.
- "!**/tests/preconditions.go"
- "!**/tests/terraform_floci_dag_test.go"
- "!**/pkg/auth/providers/**"
- "!**/pkg/store/providers/**"
- "!**/pkg/auth/identities/**"
Expand Down
45 changes: 23 additions & 22 deletions errors/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,28 +133,29 @@ func (b *ErrorBuilder) WithLocation(file string, line int) *ErrorBuilder {
// - Error message includes "container already running"
// - Hints and context from cause are preserved
func (b *ErrorBuilder) WithCause(cause error) *ErrorBuilder {
if cause != nil {
// Guard against nil b.err - if no sentinel was provided, use cause directly.
if b.err == nil {
b.err = cause
} else {
// Extract hints from cause before wrapping, since fmt.Errorf
// doesn't preserve cockroachdb hint metadata.
if causeHints := AllHints(cause); len(causeHints) > 0 {
b.hints = append(b.hints, causeHints...)
}
causeDetails := AllDetails(cause)
// Extract context from cause before wrapping, since fmt.Errorf
// doesn't preserve cockroachdb safe details metadata.
b.extractContextFromCause(cause)
// Use fmt.Errorf with double %w to maintain both errors in chain.
// This is compatible with std errors.Is() used by testify's assert.ErrorIs().
// Note: cockroachdb/errors.Wrap() only works with cockroachdb's errors.Is(),
// not the standard library's, which breaks test assertions.
b.err = fmt.Errorf("%w: %w", b.err, cause)
for _, detail := range causeDetails {
b.err = errors.WithDetail(b.err, detail)
}
if cause == nil {
return b
}
// Guard against nil b.err - if no sentinel was provided, use cause directly.
if b.err == nil {
b.err = cause
} else {
// Extract hints from cause before wrapping, since fmt.Errorf
// doesn't preserve cockroachdb hint metadata.
if causeHints := AllHints(cause); len(causeHints) > 0 {
b.hints = append(b.hints, causeHints...)
}
causeDetails := AllDetails(cause)
// Extract context from cause before wrapping, since fmt.Errorf
// doesn't preserve cockroachdb safe details metadata.
b.extractContextFromCause(cause)
// Use fmt.Errorf with double %w to maintain both errors in chain.
// This is compatible with std errors.Is() used by testify's assert.ErrorIs().
// Note: cockroachdb/errors.Wrap() only works with cockroachdb's errors.Is(),
// not the standard library's, which breaks test assertions.
b.err = fmt.Errorf("%w: %w", b.err, cause)
for _, detail := range causeDetails {
b.err = errors.WithDetail(b.err, detail)
}
}
return b
Expand Down
92 changes: 35 additions & 57 deletions errors/error_funcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,6 @@ func formatStructuredPlainError(err error, title string, suggestion string) stri
return out.String()
}

// printErrorDetails prints the explanation section from error details.
func printErrorDetails(err error) {
var out strings.Builder
appendErrorDetails(&out, err)
if out.Len() > 0 {
_, _ = os.Stderr.WriteString(out.String())
}
}

func appendErrorDetails(out *strings.Builder, err error) {
details := AllDetails(err)
if len(details) == 0 {
Expand All @@ -140,15 +131,6 @@ func appendErrorDetails(out *strings.Builder, err error) {
}
}

// printErrorHints prints the hints section, filtering out internal prefixes.
func printErrorHints(err error) {
var out strings.Builder
appendErrorHints(&out, err)
if out.Len() > 0 {
_, _ = os.Stderr.WriteString(out.String())
}
}

func appendErrorHints(out *strings.Builder, err error) {
allHints := AllHints(err)
var userHints []string
Expand All @@ -166,15 +148,6 @@ func appendErrorHints(out *strings.Builder, err error) {
}
}

// printErrorContext prints the context section from safe details.
func printErrorContext(err error) {
var out strings.Builder
appendErrorContext(&out, err)
if out.Len() > 0 {
_, _ = os.Stderr.WriteString(out.String())
}
}

func appendErrorContext(out *strings.Builder, err error) {
contextPairs := extractContextPairs(err)
if len(contextPairs) == 0 {
Expand Down Expand Up @@ -238,36 +211,7 @@ func CheckErrorAndPrint(err error, title string, suggestion string) {
// printFormattedError prints an error using the new formatter.
// If title or suggestion are provided, they are incorporated into the formatted output.
func printFormattedError(err error, title string, suggestion string) {
// If legacy title or suggestion are provided, incorporate them into the error.
if title != "" || suggestion != "" {
// Wrap error with legacy parameters using error builder.
builder := Build(err)
if suggestion != "" {
// Trim leading/trailing whitespace for analysis.
trimmed := strings.TrimSpace(suggestion)

// Check if suggestion contains markdown sections (backward compatibility).
// Old code passed suggestions like "\n## Explanation\n..." which should be
// added as explanations, not hints.
if strings.Contains(suggestion, "\n##") || strings.HasPrefix(trimmed, "##") {
// Strip the legacy "## Explanation" header if present.
cleaned := strings.TrimLeft(suggestion, "\n")
cleaned = strings.TrimPrefix(cleaned, "## Explanation\n")
cleaned = strings.TrimPrefix(cleaned, "## Explanation")
cleaned = strings.TrimSpace(cleaned)
builder = builder.WithExplanation(cleaned)
} else {
// Only add as hint if it's not empty after trimming.
// This prevents rendering empty hint lines for suggestions that are
// just whitespace or newlines.
if trimmed != "" {
builder = builder.WithHint(trimmed)
}
}
}
// Note: title is handled by the formatter's title parameter, not as a hint.
err = builder.Err()
}
err = withLegacySuggestion(err, title, suggestion)

// Check for --verbose flag (CLI flag > env var > config).
verbose := atmosConfig.Errors.Format.Verbose
Expand Down Expand Up @@ -406,3 +350,37 @@ func WrapComponentDescribeError(component, stack string, err error, context stri
// For other errors, preserve the full chain.
return fmt.Errorf("%s(%s, %s) failed: %w", context, component, stack, err)
}

// withLegacySuggestion preserves explanations and hints from legacy callers.
func withLegacySuggestion(err error, title, suggestion string) error {
// If legacy title or suggestion are provided, incorporate them into the error.
if title == "" && suggestion == "" {
return err
}
// Wrap error with legacy parameters using error builder.
builder := Build(err)
if suggestion != "" {
// Trim leading/trailing whitespace for analysis.
trimmed := strings.TrimSpace(suggestion)

// Check if suggestion contains markdown sections (backward compatibility).
// Old code passed suggestions like "\n## Explanation\n..." which should be
// added as explanations, not hints.
if strings.Contains(suggestion, "\n##") || strings.HasPrefix(trimmed, "##") {
// Strip the legacy "## Explanation" header if present.
cleaned := strings.TrimLeft(suggestion, "\n")
cleaned = strings.TrimPrefix(cleaned, "## Explanation\n")
cleaned = strings.TrimPrefix(cleaned, "## Explanation")
cleaned = strings.TrimSpace(cleaned)
builder = builder.WithExplanation(cleaned)
} else if trimmed != "" {
// Only add as hint if it's not empty after trimming.
// This prevents rendering empty hint lines for suggestions that are
// just whitespace or newlines.
builder = builder.WithHint(trimmed)
}
}
// Note: title is handled by the formatter's title parameter, not as a hint.
err = builder.Err()
return err
}
Loading
Loading