Skip to content

fix(cast): validate screengrab casts record the program name - #3629

Merged
Andriy Knysh (aknysh) merged 1 commit into
osterman/cast-prompt-2from
osterman/cast-prompt-3
Nov 5, 2026
Merged

Andriy Knysh (aknysh) merged 1 commit into
osterman/cast-prompt-2from
osterman/cast-prompt-3

Conversation

@osterman

@osterman Erik Osterman (Cloud Posse) (osterman) commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

what

  • Regenerate the last batch (136 of 412) of CLI screengrab casts with the recorder fix from fix(cast): record the program name in cast headers #3627.
  • atmos --chdir=demo/casts casts validate screengrabs cli now fails when a cast header's command does not match the manifest command. It allows the --help=all widening that the source commands use and skips atmos about --help, which a cast script records with a typed title.
  • Add unit tests for the new check.
  • Align the help page's player title with the recorded command (atmos --help).

Layer 3 of a 3-PR stack. Stacked on #3628.

why

  • Without a guard, a header like --help can ship again and render as > --help in the docs player. The check lives in this top layer because it fails until every cast in layers 1 and 2 has the corrected header.

references

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Refreshed CLI examples and help recordings to show commands with the atmos prefix, with documentation links added to many command guides.
    • Updated help content to document toolchain alias and registry commands, vendor cleanup and verification, config schema validation, and additional vendor selection options.
    • Clarified backend command descriptions and updated examples for repeatable vendor labels.
  • Bug Fixes
    • Improved validation of recorded CLI examples to detect missing or mismatched commands.

@atmos-pro

atmos-pro Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@osterman Erik Osterman (Cloud Posse) (osterman) added the no-release Do not create a new release (wait for additional code changes) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@github-actions github-actions Bot added the size/xl Extra large size PR label Nov 4, 2026
@github-actions github-actions Bot added the quality:not-ready One or more Quality Gate requirements are pending or failing label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Quality Gate   Quality Gate passed

Readiness

✅ Ready for review

✅ No merge conflicts

✅ Release label and milestone

✅ Verified commit signatures

✅ Fewer than 150 changed files

Reviews

✅ CodeRabbit approval (current head)

✅ Review threads resolved or dismissed

Measures

✅ All CI checks and workflows

✅ Codecov (current head)

✅ Benchmark results

View job summary

Current commit: 8371cb823e96567d69743a7b6b0bde59665d257c · quality:ready

Quality Gate details
Gate Status Evidence
Ready for review Passed Marked ready for review
No merge conflicts Passed No merge conflicts with the target branch
Release label and milestone Passed no-release: no release milestone required
All CI checks and workflows Passed 149 current PR CI results passed or were skipped/neutral
Codecov (current head) Passed codecov/patch: success; codecov/project: success
CodeRabbit approval (current head) Passed APPROVED
Verified commit signatures Passed 1/1 commits have GitHub-verified signatures
Review threads resolved or dismissed Passed 0 unresolved review threads (outdated threads still count)
Fewer than 150 changed files Passed 140 changed files; maximum 149
Benchmark results Passed No benchmark report processing error recorded for this head

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

CI timing summary

Latest completed GitHub Actions runs for 8371cb823e96.

  • PR wall-clock time: 13h 15m 41s
  • Aggregate runner time: 13h 24m 05s
  • Included: 16 workflows, 130 jobs (including matrix jobs)

Wall-clock time spans the earliest included workflow creation through the latest completion. Aggregate runner time adds each job's execution time, so concurrent jobs are counted separately.

Workflow Elapsed Runner time Jobs
✅ Tests 50m 56s 11h 23m 55s 110
✅ Benchmarks 37m 12s 37m 05s 1
✅ Screengrabs 24m 51s 24m 45s 2
✅ Website Preview Build 13m 57s 13m 55s 1
✅ atmos.ci 10m 33s 10m 29s 1
✅ CodeQL 9m 48s 21m 56s 6
✅ Dependency Review 4m 28s 4m 24s 1
✅ Pre-commit 4m 19s 4m 16s 1
✅ TruffleHog secret scan 55s 52s 1
✅ Validate Codeowners 36s 33s 1
✅ Verify Repository Symlinks 36s 31s 1
✅ Release Documentation Check 34s 31s 1
✅ PR Size Labeler 31s 27s 1
✅ autofix.ci 26s 23s 1
✅ Quality Gate Signal 6s 3s 1
⏹️ Release milestones 2s 0s 0
Longest jobs (top 10)
Job Workflow Duration Conclusion
benchmark Benchmarks 37m 05s ✅ success
Acceptance Tests (windows, shard 1/10) Tests 31m 04s ✅ success
build Screengrabs 24m 27s ✅ success
[race] non-acceptance test suite (shard 1/4) Tests 22m 42s ✅ success
[k3s-macos] demo-helmfile Tests 22m 32s ✅ success
Acceptance Tests (macos, shard 2/10) Tests 22m 22s ✅ success
Acceptance Tests (windows, shard 2/10) Tests 18m 22s ✅ success
Acceptance Tests (macos, shard 1/10) Tests 17m 56s ✅ success
Acceptance Tests (linux, shard 1/10) Tests 17m 48s ✅ success
[floci] go e2e Tests 17m 20s ✅ success

Updated automatically when a PR workflow finishes.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0b9e921 and 8371cb8.

Files selected for processing: 140

  • demo/casts/atmos.d/screengrabs/cli.yaml
  • demo/casts/cast_checks.py
  • demo/casts/test_screengrabs.py
  • website/docs/cli/commands/help.mdx
  • website/static/casts/screengrabs/atmos-stack-list--help.cast
  • website/static/casts/screengrabs/atmos-stack-plan--help.cast
  • website/static/casts/screengrabs/atmos-stack-schema--help.cast
  • website/static/casts/screengrabs/atmos-stack-set--help.cast
  • website/static/casts/screengrabs/atmos-stack-test--help.cast
  • website/static/casts/screengrabs/atmos-stack-validate--help.cast
  • website/static/casts/screengrabs/atmos-store--help.cast
  • website/static/casts/screengrabs/atmos-store-delete--help.cast
  • website/static/casts/screengrabs/atmos-store-get--help.cast
  • website/static/casts/screengrabs/atmos-store-list--help.cast
  • website/static/casts/screengrabs/atmos-store-set--help.cast
  • website/static/casts/screengrabs/atmos-support--help.cast
  • website/static/casts/screengrabs/atmos-support.cast
  • website/static/casts/screengrabs/atmos-terraform--help.cast
  • website/static/casts/screengrabs/atmos-terraform-apply--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend-create--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend-delete--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend-describe--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-backend-update--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-delete--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-mirror--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-prune--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-stats--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-trust--help.cast
  • website/static/casts/screengrabs/atmos-terraform-cache-untrust--help.cast
  • website/static/casts/screengrabs/atmos-terraform-clean--help.cast
  • website/static/casts/screengrabs/atmos-terraform-console--help.cast
  • website/static/casts/screengrabs/atmos-terraform-deploy--help.cast
  • website/static/casts/screengrabs/atmos-terraform-destroy--help.cast
  • website/static/casts/screengrabs/atmos-terraform-fmt--help.cast
  • website/static/casts/screengrabs/atmos-terraform-force-unlock--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-backend--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-backends--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-files--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-planfile--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-varfile--help.cast
  • website/static/casts/screengrabs/atmos-terraform-generate-varfiles--help.cast
  • website/static/casts/screengrabs/atmos-terraform-get--help.cast
  • website/static/casts/screengrabs/atmos-terraform-graph--help.cast
  • website/static/casts/screengrabs/atmos-terraform-import--help.cast
  • website/static/casts/screengrabs/atmos-terraform-init--help.cast
  • website/static/casts/screengrabs/atmos-terraform-lint--help.cast
  • website/static/casts/screengrabs/atmos-terraform-login--help.cast
  • website/static/casts/screengrabs/atmos-terraform-logout--help.cast
  • website/static/casts/screengrabs/atmos-terraform-metadata--help.cast
  • website/static/casts/screengrabs/atmos-terraform-modules--help.cast
  • website/static/casts/screengrabs/atmos-terraform-output--help.cast
  • website/static/casts/screengrabs/atmos-terraform-plan--help.cast
  • website/static/casts/screengrabs/atmos-terraform-plan-diff--help.cast
  • website/static/casts/screengrabs/atmos-terraform-providers--help.cast
  • website/static/casts/screengrabs/atmos-terraform-providers-lock--help.cast
  • website/static/casts/screengrabs/atmos-terraform-providers-mirror--help.cast
  • website/static/casts/screengrabs/atmos-terraform-providers-schema--help.cast
  • website/static/casts/screengrabs/atmos-terraform-refresh--help.cast
  • website/static/casts/screengrabs/atmos-terraform-shell--help.cast
  • website/static/casts/screengrabs/atmos-terraform-show--help.cast
  • website/static/casts/screengrabs/atmos-terraform-source--help.cast
  • website/static/casts/screengrabs/atmos-terraform-source-delete--help.cast
  • website/static/casts/screengrabs/atmos-terraform-source-describe--help.cast
  • website/static/casts/screengrabs/atmos-terraform-source-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-source-pull--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-mv--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-pull--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-push--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-replace-provider--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-rm--help.cast
  • website/static/casts/screengrabs/atmos-terraform-state-show--help.cast
  • website/static/casts/screengrabs/atmos-terraform-taint--help.cast
  • website/static/casts/screengrabs/atmos-terraform-test--help.cast
  • website/static/casts/screengrabs/atmos-terraform-untaint--help.cast
  • website/static/casts/screengrabs/atmos-terraform-validate--help.cast
  • website/static/casts/screengrabs/atmos-terraform-version--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workdir--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workdir-clean--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workdir-describe--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workdir-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workdir-show--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace-delete--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace-list--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace-new--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace-select--help.cast
  • website/static/casts/screengrabs/atmos-terraform-workspace-show--help.cast
  • website/static/casts/screengrabs/atmos-theme--help.cast
  • website/static/casts/screengrabs/atmos-theme-list--help.cast
  • website/static/casts/screengrabs/atmos-theme-show--help.cast
  • website/static/casts/screengrabs/atmos-toolchain--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-add--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-clean--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-du--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-env--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-exec--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-get--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-info--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-install--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-list--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-lock--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-path--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-registry--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-registry-list--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-registry-search--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-remove--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-search--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-set--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-uninstall--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-update--help.cast
  • website/static/casts/screengrabs/atmos-toolchain-which--help.cast
  • website/static/casts/screengrabs/atmos-validate--help.cast
  • website/static/casts/screengrabs/atmos-validate-component--help.cast
  • website/static/casts/screengrabs/atmos-validate-editorconfig--help.cast
  • website/static/casts/screengrabs/atmos-validate-schema--help.cast
  • website/static/casts/screengrabs/atmos-validate-stacks--help.cast
  • website/static/casts/screengrabs/atmos-vendor--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config-delete--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config-format--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config-get--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config-list--help.cast
  • website/static/casts/screengrabs/atmos-vendor-config-set--help.cast
  • website/static/casts/screengrabs/atmos-vendor-diff--help.cast
  • website/static/casts/screengrabs/atmos-vendor-get--help.cast
  • website/static/casts/screengrabs/atmos-vendor-pull--help.cast
  • website/static/casts/screengrabs/atmos-vendor-set--help.cast
  • website/static/casts/screengrabs/atmos-vendor-update--help.cast
  • website/static/casts/screengrabs/atmos-version--help.cast
  • website/static/casts/screengrabs/atmos-version-list--help.cast
  • website/static/casts/screengrabs/atmos-version-show--help.cast
  • website/static/casts/screengrabs/atmos-version.cast
  • website/static/casts/screengrabs/atmos-workflow--help.cast
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (0b9e921) to head (8371cb8).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           osterman/cast-prompt-2    #3629   +/-   ##
=======================================================
  Coverage                   87.21%   87.21%           
=======================================================
  Files                        3021     3021           
  Lines                      275185   275185           
=======================================================
+ Hits                       240005   240007    +2     
+ Misses                      25018    25017    -1     
+ Partials                    10162    10161    -1     
Flag Coverage Δ
unittests 87.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…name

Regenerate the last batch of CLI screengrab casts with the corrected
recorder, and make `casts validate screengrabs cli` fail when a cast
header's command does not match the manifest command, so a header like
"--help" can no longer ship and render as "> --help" in the docs player.
The `--help=all` widening used by the source commands is allowed, and
`atmos about --help` (recorded by a cast script with a typed title) is
skipped.

Also align the help page's player title with the recorded command.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@osterman

Copy link
Copy Markdown
Member Author

CodeRabbit (@coderabbitai) approve

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Action performed

Comments resolved and changes approved.

@github-actions github-actions Bot added quality:ready All Quality Gate requirements pass for the current PR head and removed quality:not-ready One or more Quality Gate requirements are pending or failing labels Nov 5, 2026
@aknysh
Andriy Knysh (aknysh) added this pull request to the merge queue Nov 5, 2026
@atmos-pro

atmos-pro Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

Merged via the queue into main with commit ce151a0 Nov 5, 2026
167 of 196 checks passed
@aknysh
Andriy Knysh (aknysh) deleted the osterman/cast-prompt-3 branch November 5, 2026 15:18
@atmos-pro

atmos-pro Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
<!-- release-pr-comment:435541441 -->
These changes were released in [v1.234.0-rc.1](https://github.com/cloudposse/atmos/releases/tag/v1.234.0-rc.1).

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
<!-- release-pr-comment:435950928 -->
These changes were released in [v1.234.0-nightly.42138010067](https://github.com/cloudposse/atmos/releases/tag/v1.234.0-nightly.42138010067).

This branch was successfully deployed

1 active and 2 inactive deployments
preview — 8371cb82 Deployed Nov 5, 2026 by github-actions[bot]
screengrabs — 8371cb82 Deployed Nov 5, 2026 by osterman via build #4243
release-notes — 8371cb82 Deployed Nov 5, 2026 by osterman via previews #3549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) quality:ready All Quality Gate requirements pass for the current PR head size/xl Extra large size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants