Repository navigation
test(pro): cover upload of all component types with resolved pro.enabled - #3719
Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
Conversation
Lock in that buildUploadInstances reports every instance (terraform and ansible alike) with its component type and the resolved pro.enabled state, including metadata.enabled=false overriding settings.pro.enabled=true, so Atmos Pro can show disabled instances and learn when they are disabled. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Quality Gate
Readiness✅ Fewer than 150 changed files Reviews✅ Review threads resolved or dismissed MeasuresCurrent commit: Quality Gate details
🤖 Next steps for this PRAtmos performanceNo significant regressions detected against the newest compatible snapshot. Describe affected
All other benchmarks
Full results are available in the comparison artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
==========================================
- Coverage 87.37% 87.36% -0.01%
==========================================
Files 3074 3285 +211
Lines 278662 296004 +17342
==========================================
+ Hits 243491 258617 +15126
- Misses 24948 26184 +1236
- Partials 10223 11203 +980
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CI timing summaryLatest completed GitHub Actions runs for
Wall-clock time spans the earliest included workflow creation through the latest completion. Aggregate runner time adds each job's execution time, so concurrent jobs are counted separately.
Longest jobs (top 10)
Updated automatically when a PR workflow finishes. |
what
buildUploadInstancesinpkg/listcovering terraform and ansible instances.pro.enabledis resolved correctly. This includesmetadata.enabled: falseoverridingsettings.pro.enabled: true.why
metadata.enabledoverride from fix(pro): respect metadata.enabled when uploading instances for drift #2563 was only exercised for some component types. This pins the behavior for all of them, so a future type-based filter can't silently drop disabled ansible instances.references
metadata.enabledwhen uploading instances for drift).testing
go test ./pkg/list -run TestBuildUploadInstances_ReportsAllTypesWithEnabledStatepasses.🤖 Generated with Claude Code