Skip to content

test(pro): cover upload of all component types with resolved pro.enabled - #3719

Open
Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
mainfrom
osterman/fix-pro-disabled-ansible
Open

Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
mainfrom
osterman/fix-pro-disabled-ansible

Conversation

@osterman

Copy link
Copy Markdown
Member

what

  • Add a regression test for buildUploadInstances in pkg/list covering terraform and ansible instances.
  • The test checks that every instance is uploaded with its component type, and that pro.enabled is resolved correctly. This includes metadata.enabled: false overriding settings.pro.enabled: true.
  • Test-only change. No production code is modified.

why

  • Atmos Pro needs to see disabled instances, ansible ones included, so it can show them and learn when they are disabled.
  • The metadata.enabled override from fix(pro): respect metadata.enabled when uploading instances for drift #2563 was only exercised for some component types. This pins the behavior for all of them, so a future type-based filter can't silently drop disabled ansible instances.

references

testing

  • go test ./pkg/list -run TestBuildUploadInstances_ReportsAllTypesWithEnabledState passes.
  • The pre-commit hooks pass, including golangci-lint.

🤖 Generated with Claude Code

Lock in that buildUploadInstances reports every instance (terraform and
ansible alike) with its component type and the resolved pro.enabled state,
including metadata.enabled=false overriding settings.pro.enabled=true, so
Atmos Pro can show disabled instances and learn when they are disabled.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@osterman Erik Osterman (Cloud Posse) (osterman) added the no-release Do not create a new release (wait for additional code changes) label Nov 17, 2026
@atmos-pro

atmos-pro Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@github-actions github-actions Bot added size/s Small size PR quality:not-ready One or more Quality Gate requirements are pending or failing labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Quality Gate   Quality Gate not ready

Readiness

✅ Ready for review

✅ No merge conflicts

✅ Release label and milestone

✅ Verified commit signatures

✅ Fewer than 150 changed files

Reviews

⚠️ CodeRabbit approval (current head) — CodeRabbit has not approved this commit.

✅ Review threads resolved or dismissed

Measures

✅ All CI checks and workflows

✅ Codecov (current head)

✅ Benchmark results

View job summary

Current commit: 8a19d4e9d072f0bbddd959984ac49c0f7ecb0964 · quality:not-ready

Quality Gate details
Gate Status Evidence
Ready for review Passed Marked ready for review
No merge conflicts Passed No merge conflicts with the target branch
Release label and milestone Passed no-release: no release milestone required
All CI checks and workflows Passed 150 current PR CI results passed or were skipped/neutral
Codecov (current head) Passed codecov/patch: success; codecov/project: success
CodeRabbit approval (current head) Not ready Pending: CodeRabbit has not approved this commit
Verified commit signatures Passed 1/1 commits have GitHub-verified signatures
Review threads resolved or dismissed Passed 0 unresolved review threads (outdated threads still count)
Fewer than 150 changed files Passed 1 changed files; maximum 149
Benchmark results Passed No benchmark report processing error recorded for this head
🤖 Next steps for this PR
PR: https://github.com/cloudposse/atmos/pull/3719
Head: 8a19d4e9d072f0bbddd959984ac49c0f7ecb0964

1. CodeRabbit approval (current head)
   Problem: CodeRabbit has not approved this commit.
   Next: Wait for CodeRabbit's current-head review. If no review is running, request one using the commands documented at https://docs.coderabbit.ai/guides/commands#manually-request-code-reviews.
   Evidence: https://github.com/cloudposse/atmos/pull/3719

Atmos performance

No significant regressions detected against the newest compatible snapshot.

Describe affected
Benchmark / metric Main snapshot (UTC) Main Current PR PR change Significance
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) 0a42ee8edeec Nov 17 18:16 5.1607 4.9317 -4.44% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) 0a42ee8edeec Nov 17 18:16 2.0405 1.9642 -3.74% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.5304 1.5095 -1.37% p=0.03546
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.5361 1.5285 -0.49% p=0.08921
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) 0a42ee8edeec Nov 17 18:16 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.8044 1.7097 -5.25% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 0a42ee8edeec Nov 17 18:16 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.5867 1.4926 -5.93% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.64602 0.60189 -6.83% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.6356 0.5985 -5.84% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.64329 0.58607 -8.90% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) 0a42ee8edeec Nov 17 18:16 3.4153 3.4157 +0.01% p=0.6842
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) 0a42ee8edeec Nov 17 18:16 3.4373 3.3999 -1.09% p=0.00105
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) 0a42ee8edeec Nov 17 18:16 3.629 3.3955 -6.44% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) 0a42ee8edeec Nov 17 18:16 33.715 33.023 -2.05% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) 0a42ee8edeec Nov 17 18:16 33.437 33.169 -0.80% p=0.07526
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) 0a42ee8edeec Nov 17 18:16 33.446 32.805 -1.92% p=4.33e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) da80d2de278b Nov 17 01:31 4.8299 4.9317 +2.11% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) da80d2de278b Nov 17 01:31 1.9396 1.9642 +1.27% p=0.00105
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) da80d2de278b Nov 17 01:31 1.4817 1.5095 +1.87% p=0.001505
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) da80d2de278b Nov 17 01:31 1.4676 1.5285 +4.15% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) da80d2de278b Nov 17 01:31 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) da80d2de278b Nov 17 01:31 1.6872 1.7097 +1.34% p=0.00105
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) da80d2de278b Nov 17 01:31 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) da80d2de278b Nov 17 01:31 1.4869 1.4926 +0.38% p=0.1655
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) da80d2de278b Nov 17 01:31 0.58385 0.60189 +3.09% p=2.165e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) da80d2de278b Nov 17 01:31 0.58448 0.5985 +2.40% p=4.33e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) da80d2de278b Nov 17 01:31 0.58511 0.58607 +0.16% p=0.4813
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) da80d2de278b Nov 17 01:31 3.3538 3.4157 +1.84% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) da80d2de278b Nov 17 01:31 3.4056 3.3999 -0.17% p=0.5288
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) da80d2de278b Nov 17 01:31 3.3131 3.3955 +2.49% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) da80d2de278b Nov 17 01:31 32.247 33.023 +2.41% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) da80d2de278b Nov 17 01:31 32.262 33.169 +2.81% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) da80d2de278b Nov 17 01:31 32.608 32.805 +0.60% p=0.6305
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) feb0556499ff Nov 17 00:37 4.9575 4.9317 -0.52% p=0.05243
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) feb0556499ff Nov 17 00:37 1.9983 1.9642 -1.71% p=0.003886
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) feb0556499ff Nov 17 00:37 1.5147 1.5095 -0.34% p=0.6842
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) feb0556499ff Nov 17 00:37 1.5091 1.5285 +1.29% p=0.008931
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) feb0556499ff Nov 17 00:37 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) feb0556499ff Nov 17 00:37 1.7435 1.7097 -1.94% p=0.0004871
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) feb0556499ff Nov 17 00:37 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) feb0556499ff Nov 17 00:37 1.5132 1.4926 -1.36% p=0.04326
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) feb0556499ff Nov 17 00:37 0.599 0.60189 +0.48% p=0.2176
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) feb0556499ff Nov 17 00:37 0.60959 0.5985 -1.82% p=0.2176
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) feb0556499ff Nov 17 00:37 0.60017 0.58607 -2.35% p=0.0003248
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) feb0556499ff Nov 17 00:37 3.4351 3.4157 -0.57% p=0.07526
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) feb0556499ff Nov 17 00:37 3.4578 3.3999 -1.68% p=0.0002057
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) feb0556499ff Nov 17 00:37 3.4443 3.3955 -1.42% p=0.0002057
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) feb0556499ff Nov 17 00:37 33.775 33.023 -2.22% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) feb0556499ff Nov 17 00:37 33.376 33.169 -0.62% p=0.02323
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) feb0556499ff Nov 17 00:37 33.684 32.805 -2.61% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) 7e563ab8f167 Nov 16 18:18 5.008 4.9317 -1.52% p=2.165e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) 7e563ab8f167 Nov 16 18:18 2.0448 1.9642 -3.94% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) 7e563ab8f167 Nov 16 18:18 1.5651 1.5095 -3.55% p=0.001505
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) 7e563ab8f167 Nov 16 18:18 1.5611 1.5285 -2.08% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) 7e563ab8f167 Nov 16 18:18 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) 7e563ab8f167 Nov 16 18:18 1.7517 1.7097 -2.40% p=0.0001299
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 7e563ab8f167 Nov 16 18:18 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) 7e563ab8f167 Nov 16 18:18 1.5403 1.4926 -3.10% p=7.578e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) 7e563ab8f167 Nov 16 18:18 0.60062 0.60189 +0.21% p=0.9118
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) 7e563ab8f167 Nov 16 18:18 0.60132 0.5985 -0.47% p=0.5288
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) 7e563ab8f167 Nov 16 18:18 0.60043 0.58607 -2.39% p=0.001505
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) 7e563ab8f167 Nov 16 18:18 3.4512 3.4157 -1.03% p=0.005196
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) 7e563ab8f167 Nov 16 18:18 3.4775 3.3999 -2.23% p=4.33e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) 7e563ab8f167 Nov 16 18:18 3.4357 3.3955 -1.17% p=0.003886
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) 7e563ab8f167 Nov 16 18:18 34.24 33.023 -3.55% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) 7e563ab8f167 Nov 16 18:18 34.015 33.169 -2.49% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) 7e563ab8f167 Nov 16 18:18 33.847 32.805 -3.08% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) 16c2dc26b548 Nov 16 15:28 5.0665 4.9317 -2.66% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) 16c2dc26b548 Nov 16 15:28 2.0708 1.9642 -5.14% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) 16c2dc26b548 Nov 16 15:28 1.5875 1.5095 -4.92% p=0.001505
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) 16c2dc26b548 Nov 16 15:28 1.586 1.5285 -3.62% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) 16c2dc26b548 Nov 16 15:28 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) 16c2dc26b548 Nov 16 15:28 1.7626 1.7097 -3.00% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 16c2dc26b548 Nov 16 15:28 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) 16c2dc26b548 Nov 16 15:28 1.5557 1.4926 -4.06% p=4.33e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) 16c2dc26b548 Nov 16 15:28 0.61596 0.60189 -2.28% p=0.006841
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) 16c2dc26b548 Nov 16 15:28 0.61482 0.5985 -2.65% p=0.002879
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) 16c2dc26b548 Nov 16 15:28 0.60842 0.58607 -3.67% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) 16c2dc26b548 Nov 16 15:28 3.5193 3.4157 -2.94% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) 16c2dc26b548 Nov 16 15:28 3.5246 3.3999 -3.54% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) 16c2dc26b548 Nov 16 15:28 3.4617 3.3955 -1.91% p=2.165e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) 16c2dc26b548 Nov 16 15:28 33.96 33.023 -2.76% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) 16c2dc26b548 Nov 16 15:28 33.997 33.169 -2.43% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) 16c2dc26b548 Nov 16 15:28 34.026 32.805 -3.59% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 4.951 4.9317 -0.39% p=0.1051
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 2.0028 1.9642 -1.92% p=7.578e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 1.5167 1.5095 -0.48% p=0.315
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 1.5261 1.5285 +0.16% p=0.8534
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) 2d6e84ce96a1 Nov 16 04:27 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 1.7344 1.7097 -1.42% p=0.006841
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 2d6e84ce96a1 Nov 16 04:27 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 1.5092 1.4926 -1.10% p=0.06301
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 0.59798 0.60189 +0.65% p=0.5787
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 0.59565 0.5985 +0.48% p=0.3527
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 0.59448 0.58607 -1.41% p=0.02881
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 3.4154 3.4157 +0.01% p=0.7394
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 3.4181 3.3999 -0.53% p=0.07526
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 3.4209 3.3955 -0.74% p=0.05243
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 33.474 33.023 -1.35% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 33.636 33.169 -1.39% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) 2d6e84ce96a1 Nov 16 04:27 33.264 32.805 -1.38% p=7.578e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) decfca13ce26 Nov 16 02:04 5.0201 4.9317 -1.76% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) decfca13ce26 Nov 16 02:04 2.0285 1.9642 -3.17% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) decfca13ce26 Nov 16 02:04 1.5404 1.5095 -2.00% p=0.001505
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) decfca13ce26 Nov 16 02:04 1.5537 1.5285 -1.62% p=0.0001299
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) decfca13ce26 Nov 16 02:04 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) decfca13ce26 Nov 16 02:04 1.7587 1.7097 -2.79% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) decfca13ce26 Nov 16 02:04 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) decfca13ce26 Nov 16 02:04 1.5402 1.4926 -3.09% p=2.165e-05
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) decfca13ce26 Nov 16 02:04 0.6095 0.60189 -1.25% p=0.03546
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) decfca13ce26 Nov 16 02:04 0.60941 0.5985 -1.79% p=0.01854
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) decfca13ce26 Nov 16 02:04 0.61058 0.58607 -4.01% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) decfca13ce26 Nov 16 02:04 3.4602 3.4157 -1.29% p=0.0007253
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) decfca13ce26 Nov 16 02:04 3.4491 3.3999 -1.43% p=0.0004871
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) decfca13ce26 Nov 16 02:04 3.4511 3.3955 -1.61% p=0.0001299
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) decfca13ce26 Nov 16 02:04 33.678 33.023 -1.94% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) decfca13ce26 Nov 16 02:04 33.898 33.169 -2.15% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) decfca13ce26 Nov 16 02:04 33.509 32.805 -2.10% p=1.083e-05
tests/benchmarks/CLI/DescribeAffected/Dependents/instances=1000-2 (sec/op) 499c4ed184f3 Nov 15 02:35 4.8692 4.9317 +1.28% p=0.0002057
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=dependents-2 (sec/op) 499c4ed184f3 Nov 15 02:35 1.9574 1.9642 +0.35% p=0.1431
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=none-2 (sec/op) 499c4ed184f3 Nov 15 02:35 1.512 1.5095 -0.16% p=0.6842
tests/benchmarks/CLI/DescribeAffected/FunctionsRepeated/instances=200/change=target-2 (sec/op) 499c4ed184f3 Nov 15 02:35 1.4942 1.5285 +2.30% p=0.0003248
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (backend-reads/op) 499c4ed184f3 Nov 15 02:35 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreCallerStacks/stacks=20/keys=11-2 (sec/op) 499c4ed184f3 Nov 15 02:35 1.7001 1.7097 +0.57% p=0.123
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 499c4ed184f3 Nov 15 02:35 22 22 +0.00% p=1
tests/benchmarks/CLI/DescribeAffected/StoreRepeated/calls=2200/keys=11-2 (sec/op) 499c4ed184f3 Nov 15 02:35 1.4908 1.4926 +0.12% p=0.3527
tests/benchmarks/CLI/DescribeAffected/instances=100/change=catalog-2 (sec/op) 499c4ed184f3 Nov 15 02:35 0.58693 0.60189 +2.55% p=0.001505
tests/benchmarks/CLI/DescribeAffected/instances=100/change=component-2 (sec/op) 499c4ed184f3 Nov 15 02:35 0.59055 0.5985 +1.35% p=0.006841
tests/benchmarks/CLI/DescribeAffected/instances=100/change=none-2 (sec/op) 499c4ed184f3 Nov 15 02:35 0.58685 0.58607 -0.13% p=0.9705
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=catalog-2 (sec/op) 499c4ed184f3 Nov 15 02:35 3.3626 3.4157 +1.58% p=0.0003248
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=component-2 (sec/op) 499c4ed184f3 Nov 15 02:35 3.3645 3.3999 +1.05% p=4.33e-05
tests/benchmarks/CLI/DescribeAffected/instances=1000/change=none-2 (sec/op) 499c4ed184f3 Nov 15 02:35 3.3411 3.3955 +1.63% p=0.003886
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=catalog-2 (sec/op) 499c4ed184f3 Nov 15 02:35 32.964 33.023 +0.18% p=0.1655
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=component-2 (sec/op) 499c4ed184f3 Nov 15 02:35 33.07 33.169 +0.30% p=0.2176
tests/benchmarks/CLI/DescribeAffected/instances=10000/change=none-2 (sec/op) 499c4ed184f3 Nov 15 02:35 32.824 32.805 -0.06% p=0.8534
All other benchmarks
Benchmark / metric Main snapshot (UTC) Main Current PR PR change Significance
internal/exec/DeferredStoreRepeated-2 (B/op) 0a42ee8edeec Nov 17 18:16 4.5688e+07 4.5688e+07 -0.00% p=0.008931
internal/exec/DeferredStoreRepeated-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 1.6287e+05 1.6287e+05 -0.00% p=0.004936
internal/exec/DeferredStoreRepeated-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.056664 0.057075 +0.73% p=0.005196
internal/exec/FindAffectedParallel-2 (B/op) 0a42ee8edeec Nov 17 18:16 1.6621e+05 1.6626e+05 +0.03% p=0.0005196
internal/exec/FindAffectedParallel-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 1848 1849 +0.05% p=0.03812
internal/exec/FindAffectedParallel-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.00069955 0.00068064 -2.70% p=0.0003248
internal/exec/LocalsRepeated-2 (B/op) 0a42ee8edeec Nov 17 18:16 2.4648e+05 2.4648e+05 +0.00% p=1
internal/exec/LocalsRepeated-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 1881 1881 +0.00% p=1
internal/exec/LocalsRepeated-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.00027795 0.00027955 +0.58% p=0.06301
internal/exec/ResolutionContextPushPop-2 (B/op) 0a42ee8edeec Nov 17 18:16 448 448 +0.00% p=1
internal/exec/ResolutionContextPushPop-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 10 10 +0.00% p=1
internal/exec/ResolutionContextPushPop-2 (sec/op) 0a42ee8edeec Nov 17 18:16 7.3465e-07 6.8145e-07 -7.24% p=1.083e-05
internal/exec/TemplateProcessingComplex-2 (B/op) 0a42ee8edeec Nov 17 18:16 2.4276e+05 2.4278e+05 +0.01% p=0.2246
internal/exec/TemplateProcessingComplex-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 497 497 +0.00% p=0.08669
internal/exec/TemplateProcessingComplex-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.00027754 0.00029147 +5.02% p=1.083e-05
pkg/list/CollectInstances-2 (B/op) 0a42ee8edeec Nov 17 18:16 53120 53120 +0.00% p=1
pkg/list/CollectInstances-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 355 355 +0.00% p=1
pkg/list/CollectInstances-2 (sec/op) 0a42ee8edeec Nov 17 18:16 3.5371e-05 3.5768e-05 +1.12% p=0.0007253
pkg/list/SortInstances-2 (B/op) 0a42ee8edeec Nov 17 18:16 9896 9896 +0.00% p=1
pkg/list/SortInstances-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 4 4 +0.00% p=1
pkg/list/SortInstances-2 (sec/op) 0a42ee8edeec Nov 17 18:16 2.1387e-05 2.1866e-05 +2.24% p=1.083e-05
pkg/merge/DeepCopyMap-2 (B/op) 0a42ee8edeec Nov 17 18:16 1224 1224 +0.00% p=1
pkg/merge/DeepCopyMap-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 12 12 +0.00% p=1
pkg/merge/DeepCopyMap-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.2225e-06 1.1605e-06 -5.07% p=1.083e-05
pkg/merge/DeepCopyMap_Large-2 (B/op) 0a42ee8edeec Nov 17 18:16 1.5686e+06 1.5686e+06 +0.00% p=1
pkg/merge/DeepCopyMap_Large-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 9374 9374 +0.00% p=1
pkg/merge/DeepCopyMap_Large-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.0014804 0.0014505 -2.02% p=1.083e-05
pkg/merge/MergeNative_FiveInputs-2 (B/op) 0a42ee8edeec Nov 17 18:16 10488 10488 +0.00% p=1
pkg/merge/MergeNative_FiveInputs-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 79 79 +0.00% p=1
pkg/merge/MergeNative_FiveInputs-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.2185e-05 1.1778e-05 -3.34% p=0.0001299
pkg/merge/MergeNative_TwoInputs-2 (B/op) 0a42ee8edeec Nov 17 18:16 4072 4072 +0.00% p=1
pkg/merge/MergeNative_TwoInputs-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 26 26 +0.00% p=1
pkg/merge/MergeNative_TwoInputs-2 (sec/op) 0a42ee8edeec Nov 17 18:16 4.223e-06 4.153e-06 -1.66% p=0.0004438
pkg/merge/Merge_ProductionScale-2 (B/op) 0a42ee8edeec Nov 17 18:16 1.0066e+05 1.0066e+05 +0.00% p=1
pkg/merge/Merge_ProductionScale-2 (allocs/op) 0a42ee8edeec Nov 17 18:16 731 731 +0.00% p=1
pkg/merge/Merge_ProductionScale-2 (sec/op) 0a42ee8edeec Nov 17 18:16 0.00014108 0.00013806 -2.14% p=1.083e-05
tests/benchmarks/CLI/DescribeStacks/StoreRepeated/calls=2200/keys=11-2 (backend-reads/op) 0a42ee8edeec Nov 17 18:16 11 11 +0.00% p=1
tests/benchmarks/CLI/DescribeStacks/StoreRepeated/calls=2200/keys=11-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.001 0.91875 -8.22% p=1.083e-05
tests/benchmarks/CLI/DescribeStacks/instances=1000-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.9827 2.0011 +0.93% p=0.06301
tests/benchmarks/CLI/ListInstances/instances=1000-2 (sec/op) 0a42ee8edeec Nov 17 18:16 1.2299 1.2269 -0.25% p=0.7959
internal/exec/DeferredStoreRepeated-2 (B/op) da80d2de278b Nov 17 01:31 4.5688e+07 4.5688e+07 -0.00% p=0.0001299
internal/exec/DeferredStoreRepeated-2 (allocs/op) da80d2de278b Nov 17 01:31 1.6287e+05 1.6287e+05 -0.00% p=0.0002273
internal/exec/DeferredStoreRepeated-2 (sec/op) da80d2de278b Nov 17 01:31 0.055636 0.057075 +2.59% p=1.083e-05
internal/exec/FindAffectedParallel-2 (B/op) da80d2de278b Nov 17 01:31 1.6618e+05 1.6626e+05 +0.05% p=2.165e-05
internal/exec/FindAffectedParallel-2 (allocs/op) da80d2de278b Nov 17 01:31 1848 1849 +0.05% p=0.0003897
internal/exec/FindAffectedParallel-2 (sec/op) da80d2de278b Nov 17 01:31 0.00067003 0.00068064 +1.58% p=7.578e-05
internal/exec/LocalsRepeated-2 (B/op) da80d2de278b Nov 17 01:31 2.4648e+05 2.4648e+05 +0.00% p=1
internal/exec/LocalsRepeated-2 (allocs/op) da80d2de278b Nov 17 01:31 1881 1881 +0.00% p=1
internal/exec/LocalsRepeated-2 (sec/op) da80d2de278b Nov 17 01:31 0.00027866 0.00027955 +0.32% p=0.315
internal/exec/ResolutionContextPushPop-2 (B/op) da80d2de278b Nov 17 01:31 448 448 +0.00% p=1
internal/exec/ResolutionContextPushPop-2 (allocs/op) da80d2de278b Nov 17 01:31 10 10 +0.00% p=1
internal/exec/ResolutionContextPushPop-2 (sec/op) da80d2de278b Nov 17 01:31 6.978e-07 6.8145e-07 -2.34% p=1.083e-05
internal/exec/TemplateProcessingComplex-2 (B/op) da80d2de278b Nov 17 01:31 2.4277e+05 2.4278e+05 +0.00% p=0.5151
internal/exec/TemplateProcessingComplex-2 (allocs/op) da80d2de278b Nov 17 01:31 497 497 +0.00% p=0.08669
internal/exec/TemplateProcessingComplex-2 (sec/op) da80d2de278b Nov 17 01:31 0.00027515 0.00029147 +5.93% p=1.083e-05
pkg/list/CollectInstances-2 (B/op) da80d2de278b Nov 17 01:31 53120 53120 +0.00% p=1
pkg/list/CollectInstances-2 (allocs/op) da80d2de278b Nov 17 01:31 355 355 +0.00% p=1
pkg/list/CollectInstances-2 (sec/op) da80d2de278b Nov 17 01:31 3.3939e-05 3.5768e-05 +5.39% p=1.083e-05
pkg/list/SortInstances-2 (B/op) da80d2de278b Nov 17 01:31 9896 9896 +0.00% p=1
pkg/list/SortInstances-2 (allocs/op) da80d2de278b Nov 17 01:31 4 4 +0.00% p=1
pkg/list/SortInstances-2 (sec/op) da80d2de278b Nov 17 01:31 2.148e-05 2.1866e-05 +1.80% p=1.083e-05
pkg/merge/DeepCopyMap-2 (B/op) da80d2de278b Nov 17 01:31 1224 1224 +0.00% p=1
pkg/merge/DeepCopyMap-2 (allocs/op) da80d2de278b Nov 17 01:31 12 12 +0.00% p=1
pkg/merge/DeepCopyMap-2 (sec/op) da80d2de278b Nov 17 01:31 1.188e-06 1.1605e-06 -2.31% p=8.66e-05
pkg/merge/DeepCopyMap_Large-2 (B/op) da80d2de278b Nov 17 01:31 1.5686e+06 1.5686e+06 +0.00% p=1
pkg/merge/DeepCopyMap_Large-2 (allocs/op) da80d2de278b Nov 17 01:31 9374 9374 +0.00% p=1
pkg/merge/DeepCopyMap_Large-2 (sec/op) da80d2de278b Nov 17 01:31 0.0014487 0.0014505 +0.13% p=0.7548
pkg/merge/MergeNative_FiveInputs-2 (B/op) da80d2de278b Nov 17 01:31 10488 10488 +0.00% p=1
pkg/merge/MergeNative_FiveInputs-2 (allocs/op) da80d2de278b Nov 17 01:31 79 79 +0.00% p=1
pkg/merge/MergeNative_FiveInputs-2 (sec/op) da80d2de278b Nov 17 01:31 1.182e-05 1.1778e-05 -0.36% p=0.9705
pkg/merge/MergeNative_TwoInputs-2 (B/op) da80d2de278b Nov 17 01:31 4072 4072 +0.00% p=1

Full results are available in the comparison artifacts.

Measurements and workflow · Full comparison artifacts

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (da80d2d) to head (8a19d4e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3719      +/-   ##
==========================================
- Coverage   87.37%   87.36%   -0.01%     
==========================================
  Files        3074     3285     +211     
  Lines      278662   296004   +17342     
==========================================
+ Hits       243491   258617   +15126     
- Misses      24948    26184    +1236     
- Partials    10223    11203     +980     
Flag Coverage Δ
unittests 87.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 251 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

CI timing summary

Latest completed GitHub Actions runs for 8a19d4e9d072.

  • PR wall-clock time: 43m 51s
  • Aggregate runner time: 14h 19m 47s
  • Included: 14 workflows, 131 jobs (including matrix jobs)

Wall-clock time spans the earliest included workflow creation through the latest completion. Aggregate runner time adds each job's execution time, so concurrent jobs are counted separately.

Workflow Elapsed Runner time Jobs
✅ Tests 43m 51s 13h 02m 15s 113
✅ Benchmarks 32m 24s 32m 19s 1
✅ atmos.ci 10m 43s 10m 41s 1
✅ CodeQL 10m 21s 22m 22s 6
✅ Pre-commit 4m 44s 4m 41s 1
✅ Dependency Review 4m 01s 3m 58s 1
✅ TruffleHog secret scan 54s 52s 1
✅ Release Documentation Check 40s 37s 1
✅ Validate Codeowners 37s 34s 1
✅ PR Size Labeler 33s 29s 1
✅ Verify Repository Symlinks 31s 28s 1
✅ autofix.ci 31s 27s 1
⏭️ landing-demos 11s 0s 1
✅ Quality Gate Signal 7s 4s 1
Longest jobs (top 10)
Job Workflow Duration Conclusion
benchmark Benchmarks 32m 19s ✅ success
[race] non-acceptance test suite (shard 3/4) Tests 28m 40s ✅ success
[race] non-acceptance test suite (shard 4/4) Tests 28m 18s ✅ success
Acceptance Tests (windows, shard 1/10) Tests 25m 30s ✅ success
Template compatibility (windows) Tests 22m 16s ✅ success
Acceptance Tests (linux, shard 1/10) Tests 21m 27s ✅ success
Acceptance Tests (windows, shard 2/10) Tests 20m 11s ✅ success
Acceptance Tests (macos, shard 1/10) Tests 20m 07s ✅ success
Acceptance Tests (windows, shard 3/10) Tests 19m 47s ✅ success
Template compatibility (macos) Tests 19m 03s ✅ success

Updated automatically when a PR workflow finishes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) quality:not-ready One or more Quality Gate requirements are pending or failing size/s Small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant