Skip to content

chore: upgrade actions to Node 24 runtime (SHA-pinned) - #38

Open
John C. Bland II (johncblandii) wants to merge 1 commit into
mainfrom
chore/node24-runtime-upgrade
Open

John C. Bland II (johncblandii) wants to merge 1 commit into
mainfrom
chore/node24-runtime-upgrade

Conversation

@johncblandii

Copy link
Copy Markdown

what

  • Bump GitHub Actions references in the workflows to versions running on the Node 24 runtime,
    SHA-pinned with precise version comments:
    • actions/checkout@v4 → @3d3c42e5... # v7.0.1
    • nick-fields/assert-action@v2 → @0efd6166... # v4.0.1

why

  • GitHub is deprecating the Node 20 runtime; affected workflows emit a deprecation warning and
    are already being force-migrated to Node 24
  • SHA pinning with a verified tag comment makes the upgrade deliberate and supply-chain-safe,
    matching the org's direction in chore: upgrade actions to Node 24 runtime and enforce SHA pinning .github#261
  • Every pinned SHA was verified against its upstream tag

references

Supersedes #37
Supersedes #36

Copilot AI lite review requested due to automatic review settings August 13, 2026 17:08
@johncblandii John C. Bland II (johncblandii) added the no-release Do not create a new release (wait for additional code changes) label Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades GitHub Actions workflow dependencies to Node 24–runtime action releases, using SHA pinning with tag comments to reduce supply-chain risk and align with the Node 20 deprecation.

Changes:

  • Replace actions/checkout@v4 with a SHA-pinned actions/checkout at v7.0.1.
  • Replace nick-fields/assert-action@v2 with a SHA-pinned nick-fields/assert-action at v4.0.1.
  • Apply these upgrades across the positive/negative workflow variants.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test-positive.yml Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions.
.github/workflows/test-positive-secret-2.yml Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions.
.github/workflows/test-negative.yml Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

- uses: nick-fields/assert-action@0efd6166067d9c59d89c710fab4f79fb066f8985 # v4.0.1
with:
expected: 'test'
actual: "${{ steps. masked-result.outputs.out }}"
- uses: nick-fields/assert-action@0efd6166067d9c59d89c710fab4f79fb066f8985 # v4.0.1
with:
expected: 'test'
actual: "${{ steps. masked-result.outputs.out }}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Test-workflows only, action.yml untouched, no-release label is correct. Both SHAs verified against upstream tags. No changes to the encode/decode logic and no new env:/with: that could surface secret material.

Copilot's two open comments on steps. masked-result are false positives — the whitespace is pre-existing on both sides of the diff, and Actions expression syntax tolerates it (both test-positive jobs pass). Safe to dismiss, though cleaning up the typo separately wouldn't hurt.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants