Repository navigation
chore: upgrade actions to Node 24 runtime (SHA-pinned) - #38
John C. Bland II (johncblandii) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades GitHub Actions workflow dependencies to Node 24–runtime action releases, using SHA pinning with tag comments to reduce supply-chain risk and align with the Node 20 deprecation.
Changes:
- Replace
actions/checkout@v4with a SHA-pinnedactions/checkoutatv7.0.1. - Replace
nick-fields/assert-action@v2with a SHA-pinnednick-fields/assert-actionatv4.0.1. - Apply these upgrades across the positive/negative workflow variants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/test-positive.yml | Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions. |
| .github/workflows/test-positive-secret-2.yml | Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions. |
| .github/workflows/test-negative.yml | Pins actions/checkout and assert-action to Node 24–compatible, SHA-verified versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - uses: nick-fields/assert-action@0efd6166067d9c59d89c710fab4f79fb066f8985 # v4.0.1 | ||
| with: | ||
| expected: 'test' | ||
| actual: "${{ steps. masked-result.outputs.out }}" |
| - uses: nick-fields/assert-action@0efd6166067d9c59d89c710fab4f79fb066f8985 # v4.0.1 | ||
| with: | ||
| expected: 'test' | ||
| actual: "${{ steps. masked-result.outputs.out }}" |
Erik Osterman (Cloud Posse) (osterman)
left a comment
There was a problem hiding this comment.
Approving. Test-workflows only, action.yml untouched, no-release label is correct. Both SHAs verified against upstream tags. No changes to the encode/decode logic and no new env:/with: that could surface secret material.
Copilot's two open comments on steps. masked-result are false positives — the whitespace is pre-existing on both sides of the diff, and Actions expression syntax tolerates it (both test-positive jobs pass). Safe to dismiss, though cleaning up the typo separately wouldn't hurt.
what
SHA-pinned with precise version comments:
actions/checkout@v4→@3d3c42e5...# v7.0.1nick-fields/assert-action@v2→@0efd6166...# v4.0.1why
are already being force-migrated to Node 24
matching the org's direction in chore: upgrade actions to Node 24 runtime and enforce SHA pinning .github#261
references
Supersedes #37
Supersedes #36