feat(orders): the customer owns the token they paid for - #3
Merged
Conversation
CF-01 — take a customer-controlled ownerAddress on the order and pass it as the constructor's owner_/recipient_ and as the SPL mint and freeze authority. Every deployed token previously minted its whole supply to a keyvault deployer address bound to the creation shape, which can sign contract creations and nothing else — so the token the customer bought existed at an address no signature would ever move. The deployer now only pays gas and never holds value, which is what that shape is safe for. CF-01a — the tiers were suspended as a stop-gap; superseded by the above. CF-21 — a reverted or dropped deploy can be retried, instead of a set txHash bricking the order for ever. CF-43 — EVM_RPC_URL / SOLANA_RPC_URL no longer claim to do something they cannot. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of an estate-wide remediation of the 49-ticket defect register in
audit.md, sequenced by the phase plan inupgrade.md. Each ticket was resolved against its own Done when boxes, then handed to an independent reviewer told to assume it was not fixed and to walk the ticket's How it fails scenario through the new code.Verification
pnpm typecheckpasses across every workspace in this repo.What has NOT been verified
Stated plainly so review effort goes to the right places:
docker compose buildreturns exit 0 while cancelling every target, so a green build here would prove nothing anyway.partialorINCOMPLETE; where any of those touch this repo they are listed in the commit body rather than hidden.🤖 Generated with Claude Code