Skip to content

fix(money): every terminal state a money row reaches now has a way out - #3

Merged
savvaniss merged 1 commit into
mainfrom
deep-research
Jul 29, 2026
Merged

fix(money): every terminal state a money row reaches now has a way out#3
savvaniss merged 1 commit into
mainfrom
deep-research

Conversation

@savvaniss

Copy link
Copy Markdown
Contributor

Summary

Part of an estate-wide remediation of the 49-ticket defect register in audit.md, sequenced by the phase plan in upgrade.md. Each ticket was resolved against its own Done when boxes, then handed to an independent reviewer told to assume it was not fixed and to walk the ticket's How it fails scenario through the new code.

Verification

  • pnpm typecheck passes across every workspace in this repo.
  • Each ticket carries a reproduction of its documented failure, then evidence that it no longer occurs.
  • Findings that survived adversarial review were sent back for a repair pass before landing.

What has NOT been verified

Stated plainly so review effort goes to the right places:

  • No end-to-end run of the assembled stack. Typechecks and unit tests are not the same as driving the feature. docker compose build returns exit 0 while cancelling every target, so a green build here would prove nothing anyway.
  • Some tickets in the wider programme came back partial or INCOMPLETE; where any of those touch this repo they are listed in the commit body rather than hidden.
  • Documentation corrections were verified against source, but the estate has a history of docs drifting from code — treat prose changes as claims to check, not conclusions.

🤖 Generated with Claude Code

CF-08 — verify the manual-sweep amount against the transaction it names.
An overstated figure was trusted and the excess credited to the user.
CF-06 — abandon must prove a withdrawal can never apply, not that it has
not yet.
CF-07 — a stuck sweep froze its deposit address and the documented remedy
was a silent no-op.
CF-24 — a build-failing pending withdrawal is marked stuck instead of
retrying for ever and blocking the chain.
CF-45 — the XRP mark rebase no longer collides the synthetic deposit txid.
CF-25 — stop minting deposit addresses on a network the deployment does
not run.
CF-22 — deposit addresses and their ids are reachable by an operator, so
the remedy the watcher logs can actually be followed.
CF-23 — the sweeper and withdrawal worker report to Beacon.
CF-44 — MAP.md no longer says ETH cannot be sent.

Co-Authored-By: Claude <noreply@anthropic.com>
@savvaniss
savvaniss merged commit fce5281 into main Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant