Skip to content

fix: accept SELECT-list trailing commas at query boundaries - #405

Merged
makenowjust merged 1 commit into
cloudspannerecosystem:mainfrom
apstndb:fix/select-list-trailing-comma
Aug 16, 2026
Merged

fix: accept SELECT-list trailing commas at query boundaries#405
makenowjust merged 1 commit into
cloudspannerecosystem:mainfrom
apstndb:fix/select-list-trailing-comma

Conversation

@apstndb

@apstndb apstndb commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #404

Spanner accepts trailing commas in shared SELECT lists at subquery and pipe boundaries. This also matches the optional trailing comma in GoogleSQL's shared select_list grammar.

Summary

  • accept SELECT-list trailing commas before ) and |>
  • cover parenthesized, EXISTS, and ARRAY subqueries as well as pipe SELECT
  • preserve canonical SQL output without the trailing comma

@makenowjust makenowjust left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@makenowjust
makenowjust merged commit 1e2be08 into cloudspannerecosystem:main Aug 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support trailing commas of SELECT-list in subqueries and pipe query

2 participants