Removed a check to see if the destination is smaller than the source. Th...#2
Open
jllamas wants to merge 1 commit intoclr:masterfrom
Open
Removed a check to see if the destination is smaller than the source. Th...#2jllamas wants to merge 1 commit intoclr:masterfrom
jllamas wants to merge 1 commit intoclr:masterfrom
Conversation
… The gem should just resize the image to whenever it is handed.
Author
|
I tested this gem update with unicron local to my box. My test set of images now properly do all the following actions: Image source larger than copy => Creates image I could not run the gem's tests as it attempts to build the gem on the fly and it fails on my mac since I can't pass the compile headers I need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...e gem should just resize the image to whenever it is handed.