Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for recursive environment variable loading from the Container, enabling factory functions to explicitly reference their own variable name. This is particularly useful for type casting, validation, and applying defaults to environment variables. The implementation temporarily unsets the factory reference during parameter loading to allow recursive lookups to fall through to environment variables.
Key changes:
- Modified
loadVariable()to temporarily unset factory during parameter loading, enabling recursive self-references - Updated error message in test to reflect new behavior where recursive factory references attempt environment lookup
- Added comprehensive test coverage for recursive factories with various scenarios (defaults, nullable types, error recovery)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Container.php | Core implementation: temporarily unsets factory during parameter loading to enable recursive environment variable references |
| tests/ContainerTest.php | Updated error message for recursive reference test; added 6 new tests covering recursive factory scenarios |
| docs/best-practices/controllers.md | Updated example to demonstrate recursive variable reference pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for loading recursive environment variables from the
Container. With these changes applied, factory functions may now explicitly reference their own variable name, which is especially useful for applying default values or casting or jugglingstringenvironment variables to their expected type likeintorfloat:This includes a number of updated tests to verify correct behavior and avoid introducing any potential regressions, so this has 100% code coverage and should be safe to apply. On top of this, I've updated the documentation slightly to showcase how this could be used to apply a default for the
X_LISTENenvironment variable. This is the next step in adding better configuration support and support for environment variables and.env(dotenv) files as discussed in #101.Builds on top of #287, #286, #284, #184, #38, and others