Refactor and simplify loading ReactiveHandler with new Container::getSapi() helper#292
Merged
Refactor and simplify loading ReactiveHandler with new Container::getSapi() helper#292
ReactiveHandler with new Container::getSapi() helper#292Conversation
clue
force-pushed
the
container-getsapi
branch
from
3c2e525 to
f70c567
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset refactors and simplifies loading the
ReactiveHandlerwith a newContainer::getSapi()helper. This is only used internally at the moment, but may be exposed as part of our public API in a follow-up. This also allows us to clean up the tests and avoid a number of reflection calls in our tests.Builds on top of #291, #289, #282, #224, #222, #38, and others