DSE topology with Kerberos and non Kerberos support - #2
Conversation
| 2017-09-20 10:18:53 PM clusterdock.topology_dse.start INFO From its node, DSE can be accessed with: cqlsh -u cassandra -p cassandra | ||
| 2017-09-20 10:18:53 PM clusterdock.cli INFO Cluster started successfully (total time: 1m 14s). | ||
|
|
||
| To start a Kerberos based DSE cluster: |
| --nodes node [node ...] | ||
| Nodes of the nodes group (default: ['node-1', | ||
| 'node-2']) | ||
| 'node-2']) |
There was a problem hiding this comment.
Looks like a duplicated line
| ARG DSE_VERSION=5.1.3-1 | ||
|
|
||
| RUN yum -y update && \ | ||
| yum -y install unzip |
There was a problem hiding this comment.
Might be a good idea to add a yum clean all line here to keep the image size down a little.
There was a problem hiding this comment.
In fact, I'd combine all of your yum lines into one here. Having them separate can make the image bloat considerably.
| unzip -jo -d ${JDK_DIRECTORY}/jre/lib/security /tmp/unlimited_jce_policy.zip && \ | ||
| rm -f /tmp/unlimited_jce_policy.zip | ||
|
|
||
| RUN update-alternatives --install "/usr/bin/java" "java" "${JDK_DIRECTORY}/bin/java" 1 |
There was a problem hiding this comment.
Can you add a comment above describing what's happening here?
| @@ -0,0 +1,5 @@ | |||
| [datastax] | |||
| name = DataStax Repo for DataStax Enterprise | |||
| baseurl=https://srid%40streamsets.com:Streamsetsme3@rpm.datastax.com/enterprise | |||
There was a problem hiding this comment.
I wouldn't put your password in like this...
| node.execute(command="bash -c '{}'".format('; '.join(dse_kdc_commands)), quiet=quiet) | ||
| # DSE config specific commands | ||
| dse_config_commands = [ | ||
| 'cp {} {}.org'.format(DSE_CASSANDRA_CONF_FILEPATH, DSE_CASSANDRA_CONF_FILEPATH), |
There was a problem hiding this comment.
Might wanna use .orig instead of .org for clarity.
| 'mkdir -p {}'.format(DSE_CQLSHRC_HOME_DIR) | ||
| ] | ||
| node.execute(command="bash -c '{}'".format('; '.join(dse_config_commands)), quiet=quiet) | ||
| # DSE cassandra.yaml mods |
There was a problem hiding this comment.
Any way to abstract away some of the duplication between this and the previous mods defined elsewhere? Might wanna have a common function that does behavior common to both and then just defer to specific Kerberos or non-Kerberos behavior from there?
| # yaml definition file for the nodebase DSE topology. | ||
|
|
||
| name: DSE | ||
| description: A Datastax (DSE) cluster |
| description: A Datastax (DSE) cluster | ||
|
|
||
| node groups: | ||
| kdc-node: |
There was a problem hiding this comment.
Is it necessary to define this here? Might just be better to always have it called kdcoupin thekdc NodeGr and not be configurable for simplicity.
| default: Test Cluster | ||
| help: DSE cluster name to use | ||
| --kerberos: | ||
| help: If specified, sets up Kerberos based DSE cluster with a KDC node |
|
Fixed for all review comments. Please review again. |
2 participants
No description provided.