fix: advisor wording 'Charging battery' → 'Battery below reserve' (v1.14.1) - #19
Merged
Conversation
…1.14.1) MODE_CHARGING means "SOC <= min_soc, devices paused" - AURUM does not measure whether the battery is actually charging, so the label claimed an activity that may not be happening. Display strings only (EN/DE, sensor state + panel); machine-readable codes unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLgEATa2NRuvft5vU4D5N3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
battery_chargingdecision/reason display labels claimed the battery is actively charging. AURUM doesn't measure that — the mode means SOC ≤min_soc, devices paused. Spotted in a live session: BYD at 2 % on a July morning, banner said "Batterie lädt" while the battery was idle.Display strings only (strings.json, translations en/de, panel fallback STRINGS). The machine-readable codes (
battery_charging) are unchanged — no breaking change for automations.Testing
Full suite green (189 passed),
node --checkOK.🤖 Generated with Claude Code
https://claude.ai/code/session_01QLgEATa2NRuvft5vU4D5N3