[cmc0619]

Summary

Rewrites BarRobot v2 around explicit configuration, recipe, planning, web, hardware-controller, and GPIO-adapter boundaries while preserving the existing route URLs, 12-slot workflow, recipe-cache schema, pantry/substitution behavior, safe mode, configurable pins, shortest-path rotation, and conservative motion ramp.

The first commit contains the complete review and behavior contract in design.md. Intentional safety and correctness changes are documented there rather than hidden in refactoring.

Important behavior changes

• migrates the shipped bottle_config.json into canonical config.json
• makes configured shot_size determine actuator repetitions
• preflights the complete recipe before any ingredient is poured
• serializes complete hardware operations
• uses POST for the menu's Pour action while retaining legacy GET compatibility
• requires an operator-established position before live movement
• distributes all 1,600 microsteps exactly around 12 slots
• invalidates position after simulated safe-mode movement or interrupted live movement
• disables Flask debug/reloader behavior by default

Developer and operator impact

• fresh-clone dependency and sample-config files now exist
• Raspberry Pi GPIO is lazy and injectable, so development and CI require no hardware
• the root app.py and hardware.py remain compatibility entry points
• README commissioning steps call out shot calibration and trusted-position setup
• version advances to 2.0.0 because the documented safety changes are intentionally breaking at the hardware boundary

Validation

• ruff format --check .
• ruff check .
• pytest — 31 passed
• python -m compileall -q app.py hardware.py barrobot tests
• git diff --check

No tests contact CocktailDB or emit Raspberry Pi GPIO.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b8f4eea8-7821-4cba-821c-ed6648c13beb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

The PR rewrites BarRobot around validated, injectable service boundaries.

• Introduces atomic configuration and recipe-cache persistence with legacy configuration migration.
• Adds preflighted shot-size-aware drink planning and serialized GPIO control.
• Adds trusted-position handling, exact slot-step distribution, safe-mode transitions, and configurable hardware adapters.
• Rebuilds the Flask routes, templates, deployment files, documentation, CI, and test suite around the v2 architecture.

Confidence Score: 2/5

This PR should not merge until actuator deassertion is exception-safe and GET requests can no longer initiate a physical pour.

A mid-press exception can leave the valve energized, while the compatibility GET route still reaches the complete live rotation-and-dispense path without an intentional POST action.

Files Needing Attention: barrobot/hardware.py, barrobot/routes.py

Important Files Changed

Filename	Overview
barrobot/hardware.py	Adds serialized motion and actuator control, but actuator presses are not exception-safe and can leave the valve energized.
barrobot/routes.py	Adds service-oriented web workflows and complete-plan locking, but the retained GET pour route can still initiate physical dispensing.
barrobot/planning.py	Adds immutable preflighted automatic/manual actions and shot-size-aware repetition calculation.
barrobot/config.py	Adds normalized validation, legacy migration, and atomic configuration persistence.
barrobot/recipes.py	Adds typed CocktailDB conversion, explicit download errors, and atomic cache persistence.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    UI[Flask routes and templates] --> Config[ConfigStore]
    UI --> Recipes[RecipeRepository]
    UI --> Planner[Drink planner]
    Config --> Planner
    Recipes --> Planner
    Planner --> Controller[HardwareController]
    Controller --> GPIO[GPIO adapter]
    GPIO --> Hardware[Turret and actuator]

Loading

_{Reviews (1): Last reviewed commit: "Add v2 UI screenshots to README (#5)" | Re-trigger Greptile}

[greptile-apps]

Actuator remains energized on failure

When the sleeper or a GPIO write raises after ACTUATOR is set high, this loop exits without reliably setting it low, causing the bottle valve to remain open and continue dispensing until cleanup or operator intervention.

[greptile-apps]

GET still executes physical pours

When a crawler, prefetch, refresh, or embedded URL sends GET for a known recipe after live position is established, the shared route body rotates the turret and presses the actuator, causing a drink to be dispensed without an intentional Pour submission.

Suggested change

	@web.route("/make_drink/<name>", methods=["GET", "POST"])
	@web.post("/make_drink/<name>")

[codacy-production]

Not up to standards ⛔

🔴 Issues 57 high · 3 medium · 2 minor

Alerts:
⚠ 62 issues (≤ 0 issues of at least minor severity)

Results:
62 new issues

Category	Results
Security	3 medium 2 minor 57 high

View in Codacy

🟢 Metrics 283 complexity · 2 duplication

Metric	Results
Complexity	283
Duplication	2

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}