-
Notifications
You must be signed in to change notification settings - Fork 729
Add separate beam defaults for alignment #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ce8fcd8
feat: add align_* beams and align_use_main_beams for forced-alignment…
lenzo-ka 12ffd21
docs: document forced-alignment beam parameters
lenzo-ka 90f2826
test: add test_align_fsg_beam
lenzo-ka 33df974
fix: disable lattice bestpath for forced-alignment FSG hypothesis
lenzo-ka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* -*- c-basic-offset: 4 -*- */ | ||
| #include <pocketsphinx.h> | ||
|
|
||
| #include "pocketsphinx_internal.h" | ||
| #include "fsg_search_internal.h" | ||
| #include "util/hash_table.h" | ||
| #include "test_macros.h" | ||
|
|
||
| int | ||
| main(int argc, char *argv[]) | ||
| { | ||
| ps_decoder_t *ps; | ||
| ps_config_t *config; | ||
| void *search_p; | ||
| fsg_search_t *fsgs; | ||
|
|
||
| (void)argc; | ||
| (void)argv; | ||
| err_set_loglevel(ERR_INFO); | ||
| /* Stock asymmetry: wbeam differs from beam; forced-align FSG must use align_* */ | ||
| TEST_ASSERT(config = | ||
| ps_config_parse_json( | ||
| NULL, | ||
| "loglevel: INFO, bestpath: false," | ||
| "hmm: \"" MODELDIR "/en-us/en-us\"," | ||
| "dict: \"" MODELDIR "/en-us/cmudict-en-us.dict\"," | ||
| "samprate: 16000," | ||
| "wbeam: 7e-29")); | ||
| TEST_ASSERT(ps = ps_init(config)); | ||
| TEST_EQUAL(0, ps_set_align_text(ps, "go forward ten meters")); | ||
| TEST_EQUAL(0, hash_table_lookup(ps->searches, PS_DEFAULT_ALIGN_SEARCH, | ||
| &search_p)); | ||
| fsgs = (fsg_search_t *)search_p; | ||
| TEST_EQUAL(fsgs->wbeam_orig, fsgs->beam_orig); | ||
| TEST_EQUAL(fsgs->pbeam_orig, fsgs->beam_orig); | ||
|
|
||
| ps_free(ps); | ||
| ps_config_free(config); | ||
|
|
||
| /* With align_use_main_beams, FSG uses global wbeam (asymmetric from beam). */ | ||
| TEST_ASSERT(config = | ||
| ps_config_parse_json( | ||
| NULL, | ||
| "loglevel: ERROR, bestpath: false," | ||
| "hmm: \"" MODELDIR "/en-us/en-us\"," | ||
| "dict: \"" MODELDIR "/en-us/cmudict-en-us.dict\"," | ||
| "samprate: 16000," | ||
| "wbeam: 7e-29," | ||
| "align_use_main_beams: yes")); | ||
| TEST_ASSERT(ps = ps_init(config)); | ||
| TEST_EQUAL(0, ps_set_align_text(ps, "go forward ten meters")); | ||
| TEST_EQUAL(0, hash_table_lookup(ps->searches, PS_DEFAULT_ALIGN_SEARCH, | ||
| &search_p)); | ||
| fsgs = (fsg_search_t *)search_p; | ||
| TEST_ASSERT(fsgs->wbeam_orig != fsgs->beam_orig); | ||
|
|
||
| ps_free(ps); | ||
| ps_config_free(config); | ||
| return 0; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be single or double backquotes?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhdaines I think this isn't really needed; I was trying to deal with the 2-pass decoding failures, but that turned out to be some fencepost errors and it's a different very small PR. I'm going to close this one, we can revisit it if it pops up.